Fixed handling of the saturate keyword when we multiply be an array. #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.data *= value | ||
| else: | ||
| self.data *= value | ||
| self.uncertainty *= value |
There was a problem hiding this comment.
Is it intentional that there is no protection for the uncertainties for negative values if value is a scalar, unlike for the array case? (Cf. line 145)
captain-exoplanet
approved these changes
Oct 30, 2020
captain-exoplanet
left a comment
captain-exoplanet
left a comment
There was a problem hiding this comment.
Looks good, my one comment need not prevent merging. Approved.
mgdaily
reviewed
Oct 30, 2020
Collaborator
mgdaily
left a comment
mgdaily
left a comment
There was a problem hiding this comment.
Looks reasonable. I think it would be a good idea to make sure we have good unit test coverage for these new cases, just to be sure that they do what we expect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.