Conversation
* fix : fix some typo errors and column rows mismatch in data * feat : new version of data * feat : complete 2021 & 2022 data * change the data structure * feat : adding data contribution page * feat : changing some data * fix: minor newline removal * fix: remove falty dir
- Updated update_dataset_index.py to generate ZIPs from data/statistics/ - Regenerated all year-based ZIP files with correct data - Added 2025_Data.zip for new budget data Downloads now match what's shown in the Interactive Browser.
- Removed find_missing_datasets.py script - Removed call from prebuild.py - missing-datasets.md is no longer generated
Summary of ChangesHello @vibhatha, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue in the download functionality, ensuring that users receive the most current and published data when using the zip download option. It achieves this by refining the data source for zip generation and simplifying the overall build process by removing an unrelated script. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with the download ZIPs by correctly updating the data path in scripts/update_dataset_index.py to data/statistics. This change ensures that only published data is included in the archives, which aligns with the PR's goal.
The PR also removes the find_missing_datasets.py script and its execution from the prebuild process. This seems to be a separate cleanup task. To maintain focus, it's often better to handle unrelated changes in a separate pull request. If this removal is intentional and part of a larger cleanup, please consider updating the PR description to reflect this for better tracking.
The code changes are correct, and I have no other issues to report.
|
📦 Documentation Build
To preview locally:
Built from commit 9e3b40f |
3 participants
The download zip option was downloading archived files. This PR updates it to latest files.