UI: Good space for two LFO controllers #8088
Conversation
The current height for the controller rack causes scrollbar to appear for the second one and on-wards. This proposal adds 30 pixels height for the rack so that there is an enough space for two LFO Controllers.
rubiefawn
left a comment
rubiefawn
left a comment
There was a problem hiding this comment.
Tested, it Looks good!
Before:
After:
Please update any lines you modify to conform to our coding conventions (a lot of our old code doesn't follow them lol).
- Spaces MUST NOT be added after an opening parenthesis or bracket
- Spaces MUST NOT be added before a closing parenthesis or bracket
Co-authored-by: Fawn <rubiefawn@gmail.com>
Co-authored-by: Fawn <rubiefawn@gmail.com>
|
I may know a possible cause to this. The additive size of window decorations is x=+4px, y=+26px, (x being comprised of 2 window borders which are 2px and y being one window border and a title, which is 24px). Setting widget size directly is better because it helps avoid confusion and defines actual visible rectangle of the widget rather than the size with arbitrary decorations (which by the way I'm pretty sure can be changed with theming). This too is one of the changes being introduced in #3532 XD |
|
Will wait a day for merge to see if anyone objects. Just to make sure I'm not rushing things after returning. |
4 participants
The current height for the controller rack causes scrollbar to appear for the second one and on-wards. This proposal adds 30 pixels height for the rack so that there is an enough space for at least two LFO Controllers, comfortably.