Skip to content

Conversation

@Jan125
Copy link
Contributor

@Jan125 Jan125 commented Oct 23, 2025

Note slides had a 1 tick delay which desynchronized them.
This may be a breaking change.

Compare these two audio files:
commbuoy_noteslide_old.mp3
commbuoy_noteslide_new.mp3

Note slides had a 1 tick delay which desynchronized them.
This may be a breaking change.
@Jan125 Jan125 marked this pull request as ready for review October 23, 2025 09:51
@Jan125
Copy link
Contributor Author

Jan125 commented Oct 23, 2025

I've not noticed any regressions so far.

@Jan125 Jan125 marked this pull request as draft October 25, 2025 22:18
@Jan125
Copy link
Contributor Author

Jan125 commented Oct 25, 2025

I have just found an issue where for discrete automation only, it triggers 1 tick too early.

@Jan125
Copy link
Contributor Author

Jan125 commented Oct 25, 2025

It seems to happen for all interactions except outvalues.
This needs a rewrite to instead check if the current position is a node and has an outvalue, and then set it to the value of the outvalue instead of the invalue for that tick.

@Jan125 Jan125 force-pushed the noteslidedelayfix branch from 66e0cf5 to fcf975b Compare October 26, 2025 07:56
@Jan125
Copy link
Contributor Author

Jan125 commented Oct 26, 2025

valueAt now returns the outValue for a node instead on an inValue by default.
For future UI usage, a bool toggle has been added to valueAt to return the inValue instead.

@Jan125 Jan125 marked this pull request as ready for review October 26, 2025 08:47
@Jan125 Jan125 changed the title Fix note slide delay of 1 tick. Make automation nodes return outValue to handle discrete jumps without delay. Oct 30, 2025
Jan125 and others added 5 commits November 3, 2025 15:53
Replace bool = 0 wit bool = false.
 - "Oopsie woopsie".

Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Co-Authored-By: Dalton Messmer <messmer.dalton@gmail.com>
Jan125 and others added 5 commits November 8, 2025 20:50
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Copy link
Member

@messmerd messmerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. The code changes look good to me - just needs some testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants