-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Make automation nodes return outValue to handle discrete jumps without delay. #8104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Note slides had a 1 tick delay which desynchronized them. This may be a breaking change.
|
I've not noticed any regressions so far. |
|
I have just found an issue where for discrete automation only, it triggers 1 tick too early. |
|
It seems to happen for all interactions except outvalues. |
66e0cf5 to
fcf975b
Compare
|
valueAt now returns the outValue for a node instead on an inValue by default. |
Replace bool = 0 wit bool = false. - "Oopsie woopsie". Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Co-Authored-By: Dalton Messmer <messmer.dalton@gmail.com>
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
Co-authored-by: Dalton Messmer <messmer.dalton@gmail.com>
messmerd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. The code changes look good to me - just needs some testing.
Note slides had a 1 tick delay which desynchronized them.
This may be a breaking change.
Compare these two audio files:
commbuoy_noteslide_old.mp3
commbuoy_noteslide_new.mp3