Make the class method docstring better reflect the return value#154
Closed
0Navin0 wants to merge 2 commits intoLSSTDESC:mainfrom
Closed
Make the class method docstring better reflect the return value#1540Navin0 wants to merge 2 commits intoLSSTDESC:mainfrom
0Navin0 wants to merge 2 commits intoLSSTDESC:mainfrom
Conversation
added 2 commits
February 9, 2026 15:23
Mention lensing magnification of SED in the doc-string.
The classes `DiffskyObject` (diffsky_object.py) and `GalaxyObject` (galaxy_object.py) inherit from `BaseObject` class (base_object.py). They redefine the method `get_total_observer_sed` to include lensing magnification but their docstrings didn't reflect that. This commit corrects the docstring to reflect for this change.
|
@0Navin0 you'll have to sync your fork and then merge |
Author
|
Thanks. I pulled the changes to my fork and again created a PR. |
|
Oh, you could have used the same PR (for next time 🙂 ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.