Conversation
|
Visit the preview URL for this PR (updated for commit e8de0a6): https://lu-explorer--pr59-tests-s0lvz6cr.web.app (expires Sun, 12 Sep 2021 11:01:24 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Getting tests working and integrated with CI is definitely a good idea. I have no experience with Angular testing, so I'll trust you that the changes are reasonable, feel free to merge. |
|
I guess the main question is whether it makes sense to need to specify the "global" service modules and pipes that are loaded by I think there'd be a way to register e.g. LuJsonService for all components by default and override it for mocks, but it may also catch more bugs to do it case by case. |
Angular generates test cases with every component template, but we haven't actually run those up until now. This branch adds the common modules to the test fixtures in the majority of places. The idea is to gate on
ng testrunning in the future using GH actions.// cc: @lcdr