Handle creating a duplicate custom new metric #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
requested changes
Dec 26, 2025
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
Please add some simple automated test coverage for this scenario.
In manual testing, I confirmed that this fixed the custom metric error handling. There's a similar repro for trace metrics that we should also address here.
| // Check if metric name already exists | ||
| this.checkMetricNameExists(metricName, function (exists) { | ||
| if (exists) { | ||
| let errorMessage = 'A metric with the name "' + Ext4.util.Format.htmlEncode(metricName) + '" already exists. Please choose a different name.'; |
Contributor
There was a problem hiding this comment.
Since you're using setText(), this ends up double-encoding.,
labkey-jeckels
approved these changes
Dec 29, 2025
| } | ||
|
|
||
| private void addCustomMetric(String projectName, String metricName, String queryName) | ||
| private void addCustomMetric(String projectName, String metricName, String queryName, boolean checkForDuplicate) |
Contributor
There was a problem hiding this comment.
Would duplicateNameErrorExpected be a better name for this parameter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/591
Related Pull Requests
Changes