Skip to content

Conversation

@zach2good
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

//
// Maybe<T>
//
// A wrapper around tl::optional to allow usage of:
// - Maybe<T&>
// - object.apply([](auto& obj) { ... })
//
//
// Variant<Ts...>
//
// A wrapper around std::variant to provide:
// - variant.has<T>() -> bool
// - variant.get<T>() -> Maybe<T&>
// - variant.visit(overload{ ... }) -> decltype(auto)
//
// https://en.cppreference.com/w/cpp/utility/variant
//

@zach2good zach2good changed the title Core: Rename xi::optional to xi::Maybe and add xi::Variant Core: Rename xi::optional to xi::Maybe and add xi::Variant and xi::Flag Nov 6, 2025
@zach2good zach2good changed the title Core: Rename xi::optional to xi::Maybe and add xi::Variant and xi::Flag Core: Rename xi::optional to xi::Maybe, Add xi::Variant, xi::Flag Nov 6, 2025
@WinterSolstice8
Copy link
Contributor

Not sure what happened here at a glance but looks like this broke some tests somehow

@zach2good zach2good added the hold On hold, pending further action/info label Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold On hold, pending further action/info

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants