-
Notifications
You must be signed in to change notification settings - Fork 797
[Status effects] Add tiers to spell effects, action choose system and related systems #9001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+690
−536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just going to link the open issue about slow/haste tiers so I can close it whenever this gets merged. |
9ac036e to
0083cb0
Compare
almuth150
reviewed
Jan 2, 2026
4d61a4b to
aa612cc
Compare
WinterSolstice8
approved these changes
Jan 2, 2026
sruon
reviewed
Jan 5, 2026
| -- Early return: Out of cone. | ||
| if | ||
| params.isConal and | ||
| not target:isInfront(caster, 64) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to the PR but this should probably be 32 (45 degrees)
Contributor
Author
|
YOLO |
4 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
And with that, the real meat:
The reason for this is because our current system doesnt handle tiers. And it also sucks, it's old and I fucking hate it, so screw it.
Steps to test these changes
Battle. Use spells.