Fix: Newline on single comments, and span of escaped characters#8
Open
lemon-gith wants to merge 4 commits intomainfrom
Open
Fix: Newline on single comments, and span of escaped characters#8lemon-gith wants to merge 4 commits intomainfrom
lemon-gith wants to merge 4 commits intomainfrom
Conversation
also inadvertently trimmed a trailing space on L27, and added changelog comments?
// no longer removes the newlines
// no longer removes that newline
// no longer removes that newline
Collaborator
|
I think the updated spec makes more sense, I've found the current one not obvious to understand at first. I'd say it would be good to merge it a few days after Lab 1 deadline (Fri 30 Jan 2026 at 15:00) in case students have any extensions, so let's say, within a week from now? What do you say @johnwickerson? The automated testing would need to be updated accordingly. Just a small note when merging later, we should remove "For 267 cohort" from the changelog. |
Contributor
|
Nice, thanks Pierce! I'll leave this hanging for a while to make sure everybody is finished with the lab, but yes, I agree that this would be good to fix for next year. I'll have to think about how to update my reference implementation to match, haha! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just what it says, I've corrected for both of these behaviours and added these new rules to the README.
Please do check and verify that the references are correct, if you have an 'ideal' flex file.
And, also feel free to add a comment to merge this later, in April, to avoid conflicts with students currently doing Lab 1.