This repository was archived by the owner on Nov 23, 2020. It is now read-only.
Define 'admin' as a Middleware Group#185
Closed
jguyomard wants to merge 1 commit intoLaravel-Backpack:masterfrom
Closed
Define 'admin' as a Middleware Group#185jguyomard wants to merge 1 commit intoLaravel-Backpack:masterfrom
jguyomard wants to merge 1 commit intoLaravel-Backpack:masterfrom
Conversation
lloy0076
approved these changes
Sep 30, 2017
Contributor
lloy0076
left a comment
lloy0076
left a comment
There was a problem hiding this comment.
Something tells me there should be some documentation re: this but that's not really part of this PR.
Member
|
Thanks a lot, @jguyomard ! I think you're totally right, it makes way more sense for it to be a middleware group, instead of a simple middleware. I merged your changes into PR #258, so I'm going to close this PR. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I think using a middleware group (instead of an alias) is a better practice here. Why? Because it allows developers to add other middlewares in the group (programmatically or using the
app/Http/Kernel.phpfile.According to me, there is no breaking changes.
I did some tests under Laravel 5.4 and Laravel 5.5.