This repository was archived by the owner on Nov 23, 2020. It is now read-only.
Avoid calling Auth multiple times.#237
Closed
AbbyJanke wants to merge 1 commit intoLaravel-Backpack:masterfrom
AbbyJanke:patch-1
Closed
Avoid calling Auth multiple times.#237AbbyJanke wants to merge 1 commit intoLaravel-Backpack:masterfrom AbbyJanke:patch-1
AbbyJanke wants to merge 1 commit intoLaravel-Backpack:masterfrom
AbbyJanke:patch-1
Conversation
Instead of recalling the `Auth::user()` instance use the `$user` variable which already calls the Auth method within the controller.
Member
|
Thank you @AbbyJanke ! Valid point. I'm going to close this in favour of #165 - which brings the option of using a custom guard across Backpack. In order to pull in the correct info, the guard needs to always be used. So that PR replaces your Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of recalling the
Auth::user()instance use the$uservariable which already calls the Auth method within the controller.This is a fix/minor change for my original PR #229