Conversation
lasley
force-pushed
the
release/0.1
branch
3 times, most recently
from
424658c to
44dd8cd
Compare
* Dockerfile * Entrypoint * Default CSR
tedsalmon
approved these changes
Jan 3, 2017
| && echo "Build complete." | ||
|
|
||
| # Create and Change to PKI Dir | ||
| RUN mkdir -p /var/pki |
Contributor
There was a problem hiding this comment.
-p is not necessarily required because /var will always exist but it also isn't hurting anything :)
Member
Author
There was a problem hiding this comment.
This is also to guard from it already existing. It's good practice in the automation to use -p
There was a problem hiding this comment.
Agree, saved me many times in the past during Clouder development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings over the CFFSL exec from clouder-community/clouder#180 & adds tests.
cc @tedsalmon @YannickB