Add support for UpdateKind::EditedMessage#29
Merged
LasterAlex merged 1 commit intoLasterAlex:latest-teloxidefrom Feb 28, 2025
Merged
Add support for UpdateKind::EditedMessage#29LasterAlex merged 1 commit intoLasterAlex:latest-teloxidefrom
LasterAlex merged 1 commit intoLasterAlex:latest-teloxidefrom
Conversation
IlyaBizyaev
force-pushed
the
feat/edited-message
branch
2 times, most recently
from
a7b08d2 to
ca19fa1
Compare
Contributor
Author
|
Or maybe, instead of introducing |
Owner
|
Ill look into this later, sorry for not responding to the the pr, i am quite busy rn, dont even have time to review :( |
LasterAlex
requested changes
Feb 27, 2025
Owner
LasterAlex
left a comment
LasterAlex
left a comment
There was a problem hiding this comment.
Looks pretty good! Thanks! Just some nitpicks
After resolving them and the merge conflict I'll merge
Owner
I like the explicit approach, so this is probably not the best idea, it will create strange to understand code |
* A wrapper is introduced that changes a Message's into_update() behavior. Having edit_date set seems to be a requirement for correct parsing. * MockBot is updated to support UpdateKind::EditedMessage. * Renamed the old Messages::edit_message to edit_message_field for clarity. * I also fixed a couple of copy-paste errors along the way.
IlyaBizyaev
force-pushed
the
feat/edited-message
branch
from
ca19fa1 to
14f0876
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Message'sinto_update()behavior. Havingedit_dateset seems to be a requirement for correct parsing.MockBotis updated to supportUpdateKind::EditedMessage.Messages::edit_messagetoedit_message_fieldfor clarity.