Conversation
Owner
|
Thanks a lot for the contribution! I will review this PR after im finished with the teloxide update |
LasterAlex
requested changes
Jul 19, 2025
Owner
LasterAlex
left a comment
LasterAlex
left a comment
There was a problem hiding this comment.
Amazing work! Just some nitpicks. Other than that i trust the tests. Also, do you have plans on adding 0.17.0? If yes, please say that, it would be bad for us to do the same work twice
| .from(MockUser::new().first_name("me").id(1234).build()); | ||
|
|
||
| let mut bot = MockBot::new(me_message.clone(), handler_tree()); | ||
| bot.dependencies(deps![get_bot_storage().await]); |
Contributor
Author
|
Thanks! Yeah, I can do 0.17.0 as well. |
Owner
|
Ok! Will wait for that, thanks a lot! I will focus on improving teloxide itself then, I have some unresolved problems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt the crate to the new teloxide version.