feat: add support for external signer instead of private key #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taekyunggg
force-pushed
the
tkyng/external-signer
branch
from
6c895d4 to
12f912b
Compare
taekyunggg
force-pushed
the
tkyng/external-signer
branch
8 times, most recently
from
75359cb to
b4efa15
Compare
taekyunggg
force-pushed
the
tkyng/external-signer
branch
4 times, most recently
from
9d41632 to
ee9385a
Compare
solimander
reviewed
Dec 9, 2025
solimander
reviewed
Dec 9, 2025
solimander
reviewed
Dec 9, 2025
solimander
reviewed
Dec 9, 2025
| expiry, | ||
| appControllerAddress: this.config.appControllerAddress as Address, | ||
| publicClient, | ||
| signMessage: this.signMessage, |
Contributor
There was a problem hiding this comment.
we need to rethink how we handle authenticated requests when using a browser wallet. currently this requests a signature on every call (every 5 seconds in watchUntilRunning). we should cache the signature until expiry and bump the expiry to something longer. should also look into sign-in sessions for the best UX
taekyunggg
force-pushed
the
tkyng/external-signer
branch
2 times, most recently
from
3423c4f to
8e453c6
Compare
taekyunggg
force-pushed
the
tkyng/external-signer
branch
from
8e453c6 to
f35c9f1
Compare
| interface WalletClientModeOptions extends BaseOptions { | ||
| walletClient: WalletClient; | ||
| publicClient: PublicClient; | ||
| privateKey?: never; |
Collaborator
There was a problem hiding this comment.
what does never mean?
Comment on lines
+62
to
+63
| // const userApiClient = new UserApiClient(environmentConfig, privateKey, rpcUrl, clientId); | ||
| // const { environmentConfig, appId, rpcUrl } = options; |
| // rpcUrl: string; | ||
| // environmentConfig: EnvironmentConfig; | ||
| // appId: Address; | ||
| // clientId?: string; |
Comment on lines
+178
to
+179
| // const userApiClient = new UserApiClient(environmentConfig, privateKey, rpcUrl, clientId); | ||
| // const { environmentConfig, appId, rpcUrl } = options; |
shrimalmadhur
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.