fix: add missing pruning logic, add missing block fk constraints #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serichoi65
reviewed
Jun 5, 2025
| select | ||
| distinct(reward_hash) as reward_hash | ||
| from ( | ||
| select reward_hash from combined_rewards where block_number >= @blockNumber |
Contributor
There was a problem hiding this comment.
The first commit must've not had the change from >= to >
serichoi65
approved these changes
Jun 5, 2025
… on rewards that were generated as part of a later date
seanmcgary
force-pushed
the
sm-fixTablePrune
branch
from
070e88a to
7acb1b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When pruning back large block distances we uncovered some inconsistencies with how data was being pruned that lead to rewards root inconsistencies.
This PR addresses a few tables subject to this and adds some missing
blocks(number)foreign key constraints for good measure.Type of change
Checklist: