Open
Conversation
All of the codes specified in [Microsoft docs](https://learn.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes) are now included in `windows.h`
Treata11
commented
Jun 19, 2024
Author
Treata11
left a comment
Treata11
left a comment
There was a problem hiding this comment.
Added the entire table of VK codes ... Also left a description for each key.
Now the project should run crossplatform.
…for this target` on non-windows platforms.
The exact procedures in `windows.h` was followed.
Leandros
reviewed
Aug 2, 2024
| #define CALLBACK __stdcall | ||
| #ifdef _WIN32 | ||
|
|
||
| #define NTAPI __stdcall |
Owner
There was a problem hiding this comment.
One of the main reasons for choosing and creating this alternative windows.h is to reduce the macros that pollute the code.
This is working against the goal.
Therefore, I'd recommend to stick with a single macro following the system reserved convention: _STDCALL.
Leandros
reviewed
Aug 2, 2024
Comment on lines
+1178
to
+1183
| HANDLE hThread | ||
| #if defined(_WIN32) || defined(_WIN64) | ||
| // FIXME: Find LPCONTEXT Alternative | ||
| , LPCONTEXT lpContext | ||
| #endif | ||
| ); |
Owner
There was a problem hiding this comment.
This will create an invalid API call. An alternative would be to define LPCONTEXT as void *.
Leandros
reviewed
Aug 2, 2024
| typedef struct _MINIDUMP_THREAD_CALLBACK { | ||
| ULONG ThreadId; | ||
| HANDLE ThreadHandle; | ||
| #if defined(_WIN32) || defined(_WIN64) |
Leandros
reviewed
Aug 2, 2024
Comment on lines
+1451
to
+1453
| #if defined(_WIN32) || defined(_WIN64) | ||
| CONTEXT Context; | ||
| #endif |
Owner
|
I'm willing to accept the keycode changes. However, the other changes warrant a further discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still plenty more
VK codesto be added ...https://learn.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes
These were a few that I found useful, but I can add them all if it's necessary ... (I've already extracted them & it's ready to be committed.)