Add tests with module type inclusion #49
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new pattern was observed on Frama-C. It is described in `examples/using_dune/lib/values/builder_sig_api/README.md`. It uses a mix of module types, functors and includes dispatched in multiple files. It is not uncommon to use a `.ml` (without `.mli`) to expose module types and reuse these in other module's `.mli`. This pattern will need to be tested more specifically. The current report semantic for the values in module types is to not report them.
It is not uncommon to use a `.ml` (without `.mli`) to expose module types and include these in other module's `.mli`. The new tests specifically target this pattern with a toplevel `include` The current report semantic for the values in module types is to not report them.
Instead of including a modtype from an external module in the signature, the same module both defines and includes a modtype in its signature. The current report semantic for the values in module types is to not report them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not uncommon to use a
.ml(without.mli) to expose module types and include these in other module's.mli. A minimal example of this pattern is reproduced inexamples/using_dune/lib/values/include_modtype. An "internal" version of this pattern, with a single module defining and including a module type, is also added to the tests.A more complex pattern, found in Frama-C, is reproduced in
examples/using_dune/lib/values/builder_sig_api. This is an extension of the above, with intermediate functors.The FP and FN introduced are tracked by #50. Expected reports reflect "the easy way" described in #50.