fix(shibboleth): use correct config key names#1005
Open
JohnVillalovos wants to merge 1 commit intodevelopfrom
Open
fix(shibboleth): use correct config key names#1005JohnVillalovos wants to merge 1 commit intodevelopfrom
JohnVillalovos wants to merge 1 commit intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Shibboleth authentication configuration loading by aligning ShibbolethOptions option key names with the post-refactor nested config structure (so ShibbolethUser can correctly read mapped attribute keys), addressing the login failure reported in #1004.
Changes:
- Update
ShibbolethOptions::InitShibbolethOptions()to useShibbolethConfigKeys::*['key']instead of hardcoded legacyshibboleth.*keys. - Add a new unit test for
ShibbolethUserattribute mapping behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
plugins/Authentication/Shibboleth/ShibbolethOptions.php |
Fixes option map keys to match the nested Shibboleth config key definitions. |
tests/Plugins/Authentication/Shibboleth/ShibbolethUserTest.php |
Adds coverage for mapping server attributes to user fields (but currently doesn’t exercise the ShibbolethOptions regression). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JohnVillalovos
force-pushed
the
jlvillal/shiboleth
branch
from
4eb11d0 to
39d0dec
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JohnVillalovos
force-pushed
the
jlvillal/shiboleth
branch
from
39d0dec to
daf082b
Compare
Previously the config file was restructured from flat keys
('shibboleth.username') to nested keys ('shibboleth' => ['username' =>
...]), and ShibbolethConfigKeys constants were updated accordingly
('key' => 'username'). But ShibbolethOptions::InitShibbolethOptions()
still used the old hardcoded 'shibboleth.username' strings when calling
SetOption().
Closes: #1004
JohnVillalovos
force-pushed
the
jlvillal/shiboleth
branch
from
daf082b to
b7056d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the config file was restructured from flat keys ('shibboleth.username') to nested keys ('shibboleth' => ['username' => ...]), and ShibbolethConfigKeys constants were updated accordingly ('key' => 'username'). But ShibbolethOptions::InitShibbolethOptions() still used the old hardcoded 'shibboleth.username' strings when calling SetOption().
Closes: #1004