Skip to content

test(phpstan): Enable phpstan level 3 typing in Controls/#1016

Merged
JohnVillalovos merged 1 commit intodevelopfrom
jlvillal/phpstan_3
Feb 15, 2026
Merged

test(phpstan): Enable phpstan level 3 typing in Controls/#1016
JohnVillalovos merged 1 commit intodevelopfrom
jlvillal/phpstan_3

Conversation

@JohnVillalovos
Copy link
Collaborator

Enable PHPStan level 3 checking for the Controls/ directory.

Fix issues found.

Enable PHPStan level 3 checking for the `Controls/` directory.

Fix issues found.
Copilot AI review requested due to automatic review settings February 15, 2026 06:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables PHPStan level 3 analysis for the Controls/ directory by removing it from the staged excludePaths list and addressing the resulting type issues via improved PHPDoc typing in dashboard controls.

Changes:

  • Stop excluding Controls/ from phpstan_next.neon analysis.
  • Widen $presenter PHPDoc types in dashboard controls to reflect the actual presenter variants assigned by subclasses.
  • Fix a PHPDoc indentation/formatting issue in MissingCheckInOutReservations.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
phpstan_next.neon Removes Controls/ from excludePaths so it is checked at level 3.
Controls/Dashboard/UpcomingReservations.php Updates $presenter PHPDoc to a union of the presenters actually used by subclasses.
Controls/Dashboard/PastReservations.php Updates $presenter PHPDoc union type and fixes a mis-indented PHPDoc block in a subclass.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JohnVillalovos JohnVillalovos enabled auto-merge (rebase) February 15, 2026 06:04
@JohnVillalovos JohnVillalovos merged commit 77f1cea into develop Feb 15, 2026
17 checks passed
@JohnVillalovos JohnVillalovos deleted the jlvillal/phpstan_3 branch February 15, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant