test(phpstan): Enable phpstan level 3 typing in Controls/#1016
Merged
JohnVillalovos merged 1 commit intodevelopfrom Feb 15, 2026
Merged
test(phpstan): Enable phpstan level 3 typing in Controls/#1016JohnVillalovos merged 1 commit intodevelopfrom
Controls/#1016JohnVillalovos merged 1 commit intodevelopfrom
Conversation
Enable PHPStan level 3 checking for the `Controls/` directory. Fix issues found.
Contributor
There was a problem hiding this comment.
Pull request overview
Enables PHPStan level 3 analysis for the Controls/ directory by removing it from the staged excludePaths list and addressing the resulting type issues via improved PHPDoc typing in dashboard controls.
Changes:
- Stop excluding
Controls/fromphpstan_next.neonanalysis. - Widen
$presenterPHPDoc types in dashboard controls to reflect the actual presenter variants assigned by subclasses. - Fix a PHPDoc indentation/formatting issue in
MissingCheckInOutReservations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
phpstan_next.neon |
Removes Controls/ from excludePaths so it is checked at level 3. |
Controls/Dashboard/UpcomingReservations.php |
Updates $presenter PHPDoc to a union of the presenters actually used by subclasses. |
Controls/Dashboard/PastReservations.php |
Updates $presenter PHPDoc union type and fixes a mis-indented PHPDoc block in a subclass. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable PHPStan level 3 checking for the
Controls/directory.Fix issues found.