Skip to content

Conversation

@gcapes
Copy link
Collaborator

@gcapes gcapes commented Jan 15, 2026

Fix #53

The previous PR (#54) should have been against develop - it was a mistake to make the PR against a feature branch.

@gcapes gcapes requested a review from aplowman as a code owner January 15, 2026 08:45
@gcapes gcapes changed the title Return none not object array Update GH actions version to enable release Jan 15, 2026
@gcapes
Copy link
Collaborator Author

gcapes commented Jan 15, 2026

@aplowman
Could you approve this after reviewing, so we can make a new release? Thanks!

@gcapes gcapes merged commit 35dada4 into develop Jan 15, 2026
9 checks passed
@gcapes gcapes deleted the return-none-not-object-array branch January 15, 2026 13:23
@gcapes
Copy link
Collaborator Author

gcapes commented Jan 15, 2026

@aplowman
This doesn't look to have worked. The release workflow has failed, complaining that the

This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v2

However, the PR contains an update to the workflow file, which uses v4. Is it somehow using the workflow file from the target branch to run the workflow?

@aplowman
Copy link
Contributor

Possibly: it's one of the other actions that might happend to use upload-artifact. I would go though all of them and check they are the latest versions. E.g. checkout and setup-python need to be updated. Also the latest upload-artifact seems to be v6 not v4.

@gcapes
Copy link
Collaborator Author

gcapes commented Jan 15, 2026

Thanks. Now done in #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants