make django js compatible for django >=1.8#1
Open
atten wants to merge 1 commit intoLightmatter:masterfrom
Open
make django js compatible for django >=1.8#1atten wants to merge 1 commit intoLightmatter:masterfrom
atten wants to merge 1 commit intoLightmatter:masterfrom
Conversation
Author
|
Already megred this pull request in my branch atten/django.js |
Member
|
I could have sworn I already did this - do we have a test harness for this? |
Member
|
hey @atten I don't want to merge this until I have a way to test it - it looks good though. I'm going to try and spend some time on the harness this weekend and them I'll merge |
|
Any progress on it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see this is maintained fork of noirbizarre/django.js, so I suggest to apply that pull request
(https://github.com/noirbizarre/django.js/pull/57/files), needed for stable work in django 1.8