Skip to content

fix(client): remove redundant clone calls #2154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
strmfos wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(client): remove redundant clone calls #2154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdk-libs/client/src/indexer/photon_indexer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ impl PhotonIndexer {
let error_message = error
.clone()
.message
.unwrap_or_else(|| format!("Unknown API error: {:?}", error).to_string());
.unwrap_or_else(|| format!("Unknown API error: {:?}", error));
return Err(IndexerError::ApiError(format!(
"API error in {} (code: {:?}): {}",
context, error.code, error_message
Expand Down
2 changes: 1 addition & 1 deletion sdk-libs/client/src/indexer/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,7 @@ impl Into<Vec<light_ctoken_sdk::compat::TokenDataWithMerkleContext>>
|token_account| light_ctoken_sdk::compat::TokenDataWithMerkleContext {
token_data: token_account.token,
compressed_account: CompressedAccountWithMerkleContext::from(
token_account.account.clone(),
token_account.account,
),
},
)
Expand Down
3 changes: 1 addition & 2 deletions sdk-libs/client/src/rpc/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@
RpcUrl::ZKTestnet
} else {
// Default to mainnet for production URLs and custom URLs
RpcUrl::Custom(url.to_string())
RpcUrl::Custom(url)
}
}

Expand Down Expand Up @@ -231,14 +231,13 @@
..Default::default()
};
let transaction = self
.client

Check warning on line 234 in sdk-libs/client/src/rpc/client.rs

View workflow job for this annotation

GitHub Actions / lint 

Diff in /home/runner/work/light-protocol/light-protocol/sdk-libs/client/src/rpc/client.rs
.get_transaction_with_config(&signature, rpc_transaction_config)
.map_err(|e| RpcError::CustomError(e.to_string()))?;
let decoded_transaction = transaction
.transaction
.transaction
.decode()
.clone()
.unwrap();
let account_keys = decoded_transaction.message.static_account_keys();
let meta = transaction.transaction.meta.as_ref().ok_or_else(|| {
Expand Down
Loading