feat: ts tests for zk examples #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move zk-id from root to zk/ folder - Add zk-nullifier: single and batch (4x) nullifier creation with Groth16 - Add zk-merkle-proof: merkle proof verification with compressed accounts - Update CI to test zk/zk-id, zk/zk-nullifier, zk/zk-merkle-proof
- zk-nullifier: Remove unused blake3 dependency - zk-id: Update merkle proof circuit import path - zk-merkle-proof: Add Anchor.toml, fix circuit import
… pattern - verifying_key.rs → nullifier_1.rs - batch_verifying_key.rs → nullifier_batch_4.rs
zk-nullifier: - Split nullifier.circom into template + nullifier_main.circom - Fixes multiple main components error when batchnullifier includes nullifier zk-merkle-proof & zk-id: - Replace Num2Bits_strict(levels) with Num2Bits(levels) - Remove redundant LessThan range check (Num2Bits already constrains) - Remove unused comparators.circom import
… pattern - nullifier.circom: template-only library (Nullifier + BatchNullifier) - nullifier_1.circom: entry point for single nullifier - nullifier_4.circom: entry point for batch of 4 nullifiers - Update setup.sh to compile new circuit files Following circomlib best practice: templates in library files, minimal entry points.
- Add nullifier circuit with Poseidon hash for single nullifier creation - Add batch nullifier circuit for creating 4 nullifiers with single proof - Include setup script for circuit compilation and key generation - Add e2e tests for both single and batch nullifier creation - Remove incomplete mixer and shielded-pool examples
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (5)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Comment on lines
-60
to
-64
| if address_tree_pubkey.to_bytes() != light_sdk::constants::ADDRESS_TREE_V2 { | ||
| msg!("Invalid address tree"); | ||
| return Err(ProgramError::InvalidAccountData.into()); | ||
| } | ||
|
|
Comment on lines
-187
to
-191
| if address_pubkey.to_bytes() != light_sdk::constants::ADDRESS_TREE_V2 { | ||
| msg!("Invalid address tree"); | ||
| return Err(ProgramError::InvalidAccountData.into()); | ||
| } | ||
|
|
tilo-14
force-pushed
the
feat/add-nullifier
branch
2 times, most recently
from
56e1f61 to
a35d669
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.