Skip to content

Update device before calling the rendering control event callback#5

Open
davidanthoff wants to merge 1 commit intoLinkplay2020:mainfrom
davidanthoff:rendering-control-event
Open

Update device before calling the rendering control event callback#5
davidanthoff wants to merge 1 commit intoLinkplay2020:mainfrom
davidanthoff:rendering-control-event

Conversation

@davidanthoff
Copy link
Contributor

This has two changes:

  • It updates the device data before it calls the event callback. I think that makes a lot more sense, as client implementations then don't have to deal with the messy details of how to update the device data.
  • It also utilizes the existing _handle_rendering_control_event function to move the data. That function existed in the code base already, but apparently wasn't used.

@Linkplay2020
Copy link
Owner

I have already modified this part of the code, so this change is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants