-
Notifications
You must be signed in to change notification settings - Fork 94
Lf 3331 move frontend from pnpm to npm rebased #3925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Duncan-Brain
wants to merge
10
commits into
integration
Choose a base branch
from
LF-3331-move-frontend-from-pnpm-to-npm-rebased
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lf 3331 move frontend from pnpm to npm rebased #3925
Duncan-Brain
wants to merge
10
commits into
integration
from
LF-3331-move-frontend-from-pnpm-to-npm-rebased
+31,111
−22,290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…explicitly -- these overrides should be upgraded first
Duncan-Brain
commented
Nov 17, 2025
| "react": "$react", | ||
| "react-dom": "$react-dom" | ||
| }, | ||
| "react-table": { |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duncan-Brain
commented
Nov 17, 2025
| "lerna": "^5.0.0", | ||
| "lint-staged": "^13.2.2", | ||
| "prettier": "^2.8.8" | ||
| "lint-staged": "^12.5.0", |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linting was failing to to spawn prettier. Matching the versions in our other packages (3.50, 12.5.0) Seems to help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Description
This one was quick to make so I tested it after doing the node upgrade. Maybe it is a good time to do it too since we are already watching for node issues.
It came about as a result of being interested in installing shared as a package (
npm i ../packages/shared). But that is not too important yet.Still open to Navs PR: #3523 -- but until we decide to do that .. consistency is nice and
pnpmis still kind of annoying for me as the main reason I might be interested in getting this merged -- we all agreed in the tech debt survey on slack shown in the jira ticket 😛...two years ago probably .Anyways.. Notes:
The core reason to use pnpm is faster installs in monorepos -- thing is... there are not many shared dependencies between our packages that are not dev related (typescript, eslint).
overridesin package.json have increased -- my understanding is that pnpm hides this well but essentially these sort of highlight packages that are....fairly deprecated or out of date so I don't mind that extra higlighting in the package lock.Jira link: LF-3331
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
pnpm i18nto help with this)