Skip to content

google java formatting #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cgardens wants to merge 1 commit into
base: master
Choose a base branch
from
Open

google java formatting #3

cgardens wants to merge 1 commit into from

Conversation

@cgardens
Copy link
Contributor

@cgardens cgardens commented Oct 12, 2018

ran google-java-format-1.5

@cgardens cgardens requested review from h-wang94 and jpefaur October 12, 2018 19:37
@h-wang94
Copy link
Contributor

h-wang94 commented Oct 15, 2018

:shipit: There's probably going to be some things that have funky formatting now just cause we traditionally have super long function names (especially the tests). But it should be fine.

jpefaur
jpefaur approved these changes Oct 16, 2018
View reviewed changes
Copy link
Contributor

@jpefaur jpefaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@h-wang94 h-wang94 removed their request for review July 30, 2019 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jpefaur jpefaur jpefaur approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cgardens @h-wang94 @jpefaur