Skip to content

Conversation

@FireFistisDead
Copy link
Contributor

Fixes

Closes #135

Description

This pull request updates the logic for exporting schedule data to external storage on Android devices. The main changes focus on improving compatibility with Android 13+ by removing unnecessary storage permission checks and saving exported files in an app-specific directory similar to WhatsApp, which enhances user privacy and file organization.

Android storage compatibility improvements:

  • Removed the check for storage permissions, since app-specific external storage on Android 13+ does not require explicit permission.
  • Changed the export directory to Android/media/com.schedulex/ScheduleX within RNFS.ExternalStorageDirectoryPath, ensuring files are saved in a modern, app-specific location. Added logic to create this directory if it does not exist.

Files Changed

Screenshots/Videos

https://drive.google.com/file/d/1poyKeMP3EY-B3JIZ7BG3dMFO-QSp4FPE/view?usp=sharing

GSSoC Contributor

  • Yes, I am a GSSoC contributor

Testing Device

  • Physical Android Device

@FireFistisDead
Copy link
Contributor Author

@Irtesaam i finally did the error of export csv in the app it will now use whatsapp like feature it will store the cvs files in android/media/com.scheduleX/ScheduleX

Copy link
Collaborator

@Irtesaam Irtesaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FireFistisDead Feature is working as expected. Just one small change: it still prints "saved to Downloads".
Update these three lines of code to use the latest path.
image

Also update settingScreen description
image

@FireFistisDead
Copy link
Contributor Author

@Irtesaam i have made the changes
photo:-
image

@FireFistisDead
Copy link
Contributor Author

image

Copy link
Collaborator

@Irtesaam Irtesaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FireFistisDead You haven’t updated line 144 in exportSchedule.ts.
Also, showing just "Saved to storage:" is a bit vague—most users won’t know it went to Android/media/com.schedulex/ScheduleX. As a temporary solution, we can print the full file path in a toast so the user at least knows where it’s saved
image

@FireFistisDead
Copy link
Contributor Author

@Irtesaam can you elaborate like should i show the directory path where it is saved or should i not

1 similar comment
@FireFistisDead
Copy link
Contributor Author

@Irtesaam can you elaborate like should i show the directory path where it is saved or should i not

@Irtesaam
Copy link
Collaborator

@Irtesaam can you elaborate like should i show the directory path where it is saved or should i not

Yes. you should. Check the image. It should show that full path.

@FireFistisDead
Copy link
Contributor Author

@Irtesaam did the changes

@Irtesaam Irtesaam merged commit 8ceef24 into Loop-Hive:main Aug 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Storage Permissions Fail on Android 13+

2 participants