Code review feedback for Dev Together June 12 #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LtBackup
reviewed
Jun 21, 2018
| }; | ||
| } | ||
|
|
||
| // MB: I love your comments describing the purpose of your functions, very helpful 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi James!
Adrian (the Mentor you had been assigned for tomorrow's event) had to back out at the last minute so I wanted to make sure that you still received code review feedback. I took a look at the React part of your app and provided some comments. It looks really great, there was a quite a bit there to review so I focused on just a few files to start.
Most of my feedback is around making sure that your components follow the single responsibility principle and encapsulate the logic they care about a little more.
If you would still like to come to tomorrow's Meetup, I'm sure we can figure out a way for you to get some valuable pairing time whether with me reviewing this feedback, or tri-pairing with a group that is also going to be going over React component architecture stuff.
Please don't hesitate to let me know if you have questions!
Mercedes