feat(application-config): add application config#3
Draft
Luke-Py-Walker wants to merge 1 commit intomasterfrom
Draft
feat(application-config): add application config#3Luke-Py-Walker wants to merge 1 commit intomasterfrom
Luke-Py-Walker wants to merge 1 commit intomasterfrom
Conversation
Luke-Py-Walker
commented
Mar 25, 2020
|
|
||
| func TestNew(t *testing.T) { | ||
| srv := New() | ||
| app, err := application.New() |
Owner
Author
There was a problem hiding this comment.
getting this error assignment mismatch: 2 variables but 1 values
@nathankhuu any idea what's happening? I thought it was a language convention...
Collaborator
There was a problem hiding this comment.
um with my limited knowledge of go lol, i think it's because you're returning only 1 thing?
goyagi/pkg/application/application.go
Line 17 in 9faa674
i think you'll add another thing to return in the next part of goyagi
Owner
Author
There was a problem hiding this comment.
lol I think it was just forgotten in this section... I'll add it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
adds application config
Why
need a way of handling environment configurations