This repository was archived by the owner on Sep 10, 2022. It is now read-only.
Open
Conversation
…8734) * added upscore to analytics-vendores test page * added upscore to vendor-request.json * added upscore.js configuration file to vendor folder * updated vendor-requests.json * cleaning out upscore.js file * alphabetic order of the vendor list * cleaning up upscore confing
* title test * query param test * add params and rename * remove referrer
* check for false * toggle exp for whole test
* Fix IE11 with a basic polyfill * review feedback
* Add test, flag, code * Add externs * Add viewport getScrollingElement getter. * Remove extends
…#18975) * add details of end-of-year pause in releases * add note about P0s
…pproject#18905) * Add test, flag, code * Only use for scrollbound animations * Add externs * Add externs * Add viewport getScrollingElement getter. * Fix issues * Add viewport getScrollingElement getter. * Remove extends
* tweak insertion * renaming * start next after view * change interval * closure * test * rename
* create attr * comments * example * naming
* amp-analytics: allow use of iframe with inabox Transport iframe nearly works with Inabox; the only difference is that in Inabox the frame always goes within the ad instead of having one frame at the top level shared between all the ads. Revival of ampproject#17539 * fix lint error * fix ampAdResourceId type * lint
…osition is changed after animation. (ampproject#18918)
Do not use win.top when trying to open a window, it could belong to a different origin.
Resolves the noscript parts of ampproject#18965
…t#18907) * Adding test for post message * fixing FSA format in tests * fixing nits * fixing presubmits
…mpproject#19003) message differences due to parser differences.
…ct#19007) * Proactively refresh overflow to avoid rendering bugs on iOS * tests * cleanup
…19311) * move config code to its own file * address comments * nit
…9250) * visual and interactive test for tooltip * wip * add couple more cases * wip * wip * re add amptest = true * tweak tooltip buttons to make them work in firefox * use waitfor(ms) only when needed * remove fortest flag
* handle esm case * fix how we dynamically fetch scripts for single pass experiment * fix tests * remove erroneous arg * store path in var
* move Percy installation to visual-diff task * fix try catch logic * use Yarn lockfile to control opt dependencies installation * Ignore node modules in presubmit check
* feat(adyoulike): initial commit * feat(adyoulike): implement renderStart * feat(adyoulike): set placement id on example
* Update link to JWT token generation documentation * Update more broken LaterPay docs links
* add validation rules for clickable tooltip * fix examples * adds data as valid icon url
* remove undef * use name again :)
…roject#19384) * Clear all platforms on reAuthorise * fix test
…ject#18954) * amp-ima-video: Show sound and fullscreen buttons during ads * add #ima-countdown to replace ad counter * use data-ad-label to support custom ad countdown label for i18n * smaller controls for ads that are mobile&skippable, fix fullscreen bug * Set font-family in controlsDiv
This was referenced Nov 20, 2018
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have merged from the origin and resolved the conflicts.
This should be ready to be merged into Lullabot/amphtml master branch.