Skip to content

fix: handle mining.extranonce.subscribe and prevent nil pointer crash - STG #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abs2023 merged 4 commits into from
Feb 10, 2026
Merged

fix: handle mining.extranonce.subscribe and prevent nil pointer crash - STG #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb9b245
fix: Update subgraph client URLs in tests
Jan 30, 2026
ddec6a4
fix: Update subgraph client URLs in tests (#82)
abs2023 Jan 30, 2026
3d2a337
fix: handle mining.extranonce.subscribe and prevent nil pointer crash
Feb 10, 2026
04c4d0a
fix: handle mining.extranonce.subscribe and prevent nil pointer crash…
abs2023 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/repositories/subgraph/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (
)

func TestGetAllPositions(t *testing.T) {
client := NewClient("https://graphidx.dev.lumerin.io/subgraphs/name/marketplace")
client := NewClient("https://api.studio.thegraph.com/query/1724245/lumerin-dev-futures/version/latest")
deliveryAt := time.Unix(1763679600, 0)
positions, err := client.GetAllPositions(context.Background(), deliveryAt)
fmt.Printf("%+v\n", positions)
Expand All @@ -20,7 +20,7 @@ func TestGetAllPositions(t *testing.T) {
}

func TestGetPositionsBySeller(t *testing.T) {
client := NewClient("https://graphidx.dev.lumerin.io/subgraphs/name/marketplace")
client := NewClient("https://api.studio.thegraph.com/query/1724245/lumerin-dev-futures/version/latest")
participantAddress := common.HexToAddress("0xb4b12a69fdbb70b31214d4d3c063752c186ff8de")
deliveryAt := time.Unix(1763679600, 0)
positions, err := client.GetPositionsBySeller(context.Background(), participantAddress, deliveryAt)
Expand Down
5 changes: 5 additions & 0 deletions internal/resources/hashrate/proxy/handler_first_connect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,11 @@ func (p *HandlerFirstConnect) handleSource(ctx context.Context, msg i.MiningMess
case *m.MiningAuthorize:
return nil, p.onMiningAuthorize(ctx, msgTyped)

case *m.MiningExtranonceSubscribe:
// Pass through extranonce subscription to pool
p.proxy.logDebugf("forwarding mining.extranonce.subscribe from source")
return nil, p.proxy.dest.Write(ctx, msgTyped)

case *m.MiningSubmit:
return nil, fmt.Errorf("unexpected handshake message from source: %s", string(msg.Serialize()))

Expand Down
18 changes: 17 additions & 1 deletion internal/resources/hashrate/proxy/proxy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,5 +450,21 @@ func (p *Proxy) logErrorf(template string, args ...interface{}) {
p.logWithContext(p.log.Errorw, template, args...)
}
func (p *Proxy) logWithContext(logFn func(t string, a ...interface{}), t string, a ...interface{}) {
logFn(fmt.Sprintf(t, a...), "DstAddr", p.dest.ID(), "DstPort", lib.ParsePort(p.dest.conn.conn.LocalAddr().String()))
logFields := []interface{}{}

// Add destination address if available
if p.dest != nil {
logFields = append(logFields, "DstAddr", p.dest.ID())

// Add port if connection is established
if p.dest.conn != nil && p.dest.conn.conn != nil {
logFields = append(logFields, "DstPort", lib.ParsePort(p.dest.conn.conn.LocalAddr().String()))
} else {
logFields = append(logFields, "DstPort", "not-connected")
}
} else {
logFields = append(logFields, "DstAddr", "not-initialized", "DstPort", "not-connected")
}

logFn(fmt.Sprintf(t, a...), logFields...)
}
Loading