Skip to content

fix: add nil check before writing to dest in handshake handle - LMN #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abs2023 merged 3 commits into from
Feb 10, 2026
Merged

fix: add nil check before writing to dest in handshake handle - LMN #88

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
72efee0
fix: add nil check before writing to dest in handshake handler
Feb 10, 2026
fb90d90
fix: add nil check before writing to dest in handshake handler (#86)
abs2023 Feb 10, 2026
5884308
fix: add nil check before writing to dest in handshake handle - STG (…
abs2023 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions internal/resources/hashrate/proxy/handler_first_connect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,22 @@ func (p *HandlerFirstConnect) handleSource(ctx context.Context, msg i.MiningMess
case *m.MiningExtranonceSubscribe:
// Pass through extranonce subscription to pool
p.proxy.logDebugf("forwarding mining.extranonce.subscribe from source")
return nil, p.proxy.dest.Write(ctx, msgTyped)
if p.proxy.dest != nil {
return nil, p.proxy.dest.Write(ctx, msgTyped)
}
return nil, nil

case *m.MiningSubmit:
return nil, fmt.Errorf("unexpected handshake message from source: %s", string(msg.Serialize()))

default:
p.proxy.logWarnf("unknown handshake message from source: %s", string(msg.Serialize()))
// todo: maybe just return message, so pipe will write it
return nil, p.proxy.dest.Write(ctx, msgTyped)
// Only forward if destination is initialized
if p.proxy.dest != nil {
return nil, p.proxy.dest.Write(ctx, msgTyped)
}
// Drop message if destination not ready
return nil, nil
}
}

Expand Down
Loading