Skip to content

integrate npm run build in CI workflows#40

Merged
SudiptaPaul-31 merged 4 commits intoLumina-eX:mainfrom
Nacho1499:feature/ci-enhancement
Feb 25, 2026
Merged

integrate npm run build in CI workflows#40
SudiptaPaul-31 merged 4 commits intoLumina-eX:mainfrom
Nacho1499:feature/ci-enhancement

Conversation

@Nacho1499
Copy link
Contributor

closes #27

Problem Statement:
Currently, there is no automated check to ensure that new code doesn't break the build process. Contributors have to manually verify builds, which can lead to broken code in the main branch.

PR Description:
This PR adds a GitHub Actions workflow (ci.yml) that automatically triggers on every pull request to main and develop.

Key Changes:

  • Automated Build: Runs npm run build on every PR.
  • Linting: Includes npm run lint to enforce code quality.
  • Caching: Configured actions/setup-node with cache: 'npm' to speed up workflow execution.
  • Reproducibility: Uses npm ci instead of npm install for consistent environments.

Verification:

  • Workflow triggers on PR creation.
  • Node.js environment sets up correctly (v20).
  • Dependencies install successfully.
  • npm run build completes without errors.

Nacho1499 and others added 4 commits February 25, 2026 09:18
- Replaced useEffect state update with lazy state initialization
- Prevents cascading renders and improves mount performance
- Resolves 'react-hooks/set-state-in-effect' failure in GitHub Actions"
@Nacho1499
Copy link
Contributor Author

"Refactored ThemeToggle to fix the CI linting errors properly.
Instead of just silencing the warning, I implemented lazy state initialization to prevent cascading renders and fixed a hook-placement issue found during the merge. The component is now more performant and the CI is good."

By fixing the code instead of ignoring the error, i have successfully:
Validated the CI setup: this proved the linting rules are active and enforcing standards.
Improved the codebase: i left the project better than you found it.

@Nacho1499
Copy link
Contributor Author

Screenshot_25-2-2026_93038_github com

@Nacho1499
Copy link
Contributor Author

Screenshot_25-2-2026_92443_github com

@Nacho1499
Copy link
Contributor Author

Screenshot_25-2-2026_10312_github com

@SudiptaPaul-31 SudiptaPaul-31 merged commit d44a799 into Lumina-eX:main Feb 25, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: CI Enhancement: Integrate npm run build in Workflows

2 participants