Add setting to also hide GPS data #4046
Conversation
📝 WalkthroughWalkthroughIntroduces configurable GPS coordinate visibility: resource models now conditionally expose latitude/longitude/altitude based on config and authentication; a migration adds two config keys to control GPS display; translations and the settings UI are updated to surface the new options across locales. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ❌ 1❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (7)
lang/cz/settings.php (1)
70-71: Missing Czech translation for new GPS coordinate settings.The new translation keys contain English text instead of Czech translations. Other entries in the
geolocationsection are properly translated to Czech (e.g.,'map_display' => 'Display the map given GPS coordinates'should also be Czech but isn't—this may be a pre-existing issue).Consider translating these to Czech for consistency:
gps_coordinate_display→ e.g., "Zobrazit GPS souřadnice"gps_coordinate_display_public→ e.g., "Povolit anonymním uživatelům přístup k GPS souřadnicím"lang/ar/settings.php (1)
71-72: Missing Arabic translation for new GPS coordinate settings.The new translation keys contain English text, but other entries in the
geolocationsection are properly translated to Arabic (e.g., Line 64:'map_display' => 'عرض الخريطة بناءً على إحداثيات GPS').These entries should be translated to Arabic for consistency with the rest of the file.
lang/fr/settings.php (1)
71-72: Missing French translation for new GPS coordinate settings.The new translation keys contain English text, but other entries in the
geolocationsection are properly translated to French (e.g., Line 64:'map_display' => 'Afficher la carte selon les coordonnées GPS').Consider translating these to French:
gps_coordinate_display→ e.g., "Afficher les coordonnées GPS"gps_coordinate_display_public→ e.g., "Permettre aux utilisateurs anonymes d'accéder aux coordonnées GPS"lang/it/settings.php (1)
71-72: Translation missing: strings are in English instead of Italian.The new GPS coordinate display settings are in English. For consistency with the rest of this Italian translation file, these should be translated:
'gps_coordinate_display' => 'Display the GPS coordinates'→ Italian translation needed'gps_coordinate_display_public' => 'Allow anonymous users to access the GPS coordinates'→ Italian translation neededlang/sv/all_settings.php (2)
72-73: Consider spelling out the coordinate fields in the label.If the setting also hides altitude, a more explicit label helps avoid ambiguity.
💡 Suggested wording
- 'gps_coordinate_display' => 'Display the GPS coordinates.', - 'gps_coordinate_display_public' => 'Allow anonymous users to access the GPS coordinates.', + 'gps_coordinate_display' => 'Display GPS coordinates (latitude, longitude, altitude).', + 'gps_coordinate_display_public' => 'Allow anonymous users to access GPS coordinates (latitude, longitude, altitude).',
399-402: Clarify that altitude is included if it’s hidden too.If altitude is gated by this setting, the details copy should mention it explicitly.
💡 Suggested wording
- 'gps_coordinate_display' => 'Disabling this hides the Latitude and Longitude information from all users.', - 'gps_coordinate_display_public' => 'Disabling this hides the Latitude and Longitude information from anonymous users.', + 'gps_coordinate_display' => 'Disabling this hides latitude, longitude, and altitude for all users.', + 'gps_coordinate_display_public' => 'Disabling this hides latitude, longitude, and altitude for anonymous users.',database/migrations/2026_01_29_170000_hide_gps_coordinates.php (1)
15-17: PHPDoc array shape is missing thedetailskey.This can mislead readers and static analysis because
detailsis present in each config entry.♻️ Suggested docblock fix
- * `@return` array<int,array{key:string,value:string,is_secret:bool,cat:string,type_range:string,description:string,order?:int,not_on_docker?:bool,is_expert?:bool,level?:int}> + * `@return` array<int,array{key:string,value:string,is_secret:bool,cat:string,type_range:string,description:string,details:string,order?:int,not_on_docker?:bool,is_expert?:bool,level?:int}>
Codecov Report❌ Patch coverage is 🚀 New features to boost your workflow:
|
Fixes #968
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.