Skip to content

Conversation

@BramOtte
Copy link
Contributor

@BramOtte BramOtte commented Jan 10, 2025

There was an inconsistency between the normal ticking and the ticking of the redpiler direct backend
Where redpiler could schedule a tick inside of the tick method but the normal tick could not.
This might also explain some inconsistent behaviour between redpiler and the normal tick but I have not tested this yet.

Additionally it seems vanilla schedules this tick after updating the block-state while redpiler did this before updating.

I have tested the changes on Iris with the mandlebrot program on redpiler and it does not seem to break things, I haven't tested it much outside of that yet.
So I do still need to test the default backend.

@BramOtte
Copy link
Contributor Author

It seems tests have failed, I almost forgot we had those, so i'l need to figure out what goes wrong here and probably need to do some more tests before this can be merged

@StackDoubleFlow
Copy link
Member

This is a risky change. I would be interested in seeing a concrete example of a build being affected by this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants