Skip to content

Add switch to disable custom Skin URL Connection (--disableSkinFix). #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jade-TheCat wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add switch to disable custom Skin URL Connection (--disableSkinFix). #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e0f7df
Add switch to disable custom Skin URL Connection (--disableSkinFix). …
Jade-TheCat Dec 27, 2025
67aa5b0
Swap order of constructor parameters in launchwrapper-micromixin tweak.
Jade-TheCat Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...cromixin/src/main/java/org/mcphackers/launchwrapper/micromixin/tweak/MicroMixinTweak.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public class MicroMixinTweak extends Tweak {
protected MicroMixinTweaker microMixinTweaker = new MicroMixinTweaker();
protected MicroMixinInjection microMixinInjection = new MicroMixinInjection(mods, microMixinTweaker);

public MicroMixinTweak(LaunchConfig launch, Tweak tweak) {
public MicroMixinTweak(Tweak tweak, LaunchConfig launch) {
super(launch);
if (tweak == null) {
throw new NullPointerException("tweak mustn't be null");
Expand Down
1 change: 1 addition & 0 deletions src/main/java/org/mcphackers/launchwrapper/LaunchConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ public class LaunchConfig {
public final LaunchParameterSwitch survival = new LaunchParameterSwitch("survival", false, true);
public final LaunchParameterString serverURL = new LaunchParameterString("serverURL", null, true);
public final LaunchParameterString serverSHA1 = new LaunchParameterString("serverSHA1", null, true);
public final LaunchParameterSwitch disableSkinFix = new LaunchParameterSwitch("disableSkinFix", false, true);
// clang-format on

private static File getDefaultGameDir() {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/org/mcphackers/launchwrapper/protocol/MinecraftURLStreamHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ protected URLConnection openConnection(URL url) throws IOException {
return new ListLevelsURLConnection(url, levelSaveDir);
if (path.startsWith("/MinecraftResources/") || path.startsWith("/resources/"))
return new AssetURLConnection(url, assets);
if (path.startsWith("/MinecraftSkins/") || path.startsWith("/skin/") || path.startsWith("/MinecraftCloaks/") || path.startsWith("/cloak/"))
if (!config.disableSkinFix.get() && (path.startsWith("/MinecraftSkins/") || path.startsWith("/skin/") || path.startsWith("/MinecraftCloaks/") || path.startsWith("/cloak/")))
return new SkinURLConnection(url, skins);
if (host.equals("assets.minecraft.net") && path.equals("/1_6_has_been_released.flag"))
if (config.oneSixFlag.get())
Expand Down