Conversation
|
Thanks for reaching out. We also have colleauge who are using torch_sim for his research, so having SevenNet maintain this is reasonable. I have a few questions regarding this PR.
|
This is a complete PR for the whole interface and it already includes a test factory to check the ASE calculator against the model interface for a suite of I am of the opinion that the ts interface is just as simple as ASE. You take in a SimState and then return it with energy, force and stress predictions. Whether or not the model prediction is batched by an implementation isn't enforced by the interface. All the MD/Relax etc are then batched but the main speed-ups come from avoiding the serial model calls as you have with ASE.
The interface as it is has been stable since July 2025 when we renamed
Plan is just to wrap upstream implementations to keep existing scripts backward compatible. If we did decide to remove the models from the ts namespace in the future we would likely post a similar discussion issue 3-6 months in advance. |
| ) | ||
|
|
||
| data_list = [] | ||
| for sys_idx in range(n_systems): |
There was a problem hiding this comment.
This implementation could be sped up using a batched neighbour list e.g. https://github.com/venkatkapil24/batch_nl or https://github.com/TorchSim/torch-sim/blob/main/torch_sim/neighbors/alchemiops.py
Hello, we think ts is getting to a fairly mature point now and we would like to encourge what we have called external model posture similar to ase (TorchSim/torch-sim#120) I have made this PR as a basic demo of what an external implementation might look like for SevenNet TorchSim/torch-sim#429.
I made some basic changes to the CI to add linting and using uv for test env such that ts will resolve properly for > py312 whilst still pointing to the external model PR. Draft until that PR get's merged/0.5.2 release.