Issue 1 accessory address translation fix#2
Open
MonitorComputing wants to merge 6 commits intoMERG-DEV:masterfrom
Open
Issue 1 accessory address translation fix#2MonitorComputing wants to merge 6 commits intoMERG-DEV:masterfrom
MonitorComputing wants to merge 6 commits intoMERG-DEV:masterfrom
Conversation
…ted, in order to get proper test results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this will fix the problem encountered with addressing accessories beyond 252, although the issue recurs at various addresses. I have done some tweaks and additions just to be able to bench test my changes so it might be that you just want to cherry pick alterations to packet_gen.c rather than merging in my test file, shell script, and logs.