Skip to content

Immersed boundaries integration with IGR #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cowsreal wants to merge 6 commits into
base: master
Choose a base branch
from
+321 −58
Open

Immersed boundaries integration with IGR #1095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af75f84
Integrate IBM with IGR
Dec 18, 2025
1340497
Add comments
Dec 19, 2025
b07045b
Minor fixes
Dec 19, 2025
489bc7c
Change from using jac_sf to jac
Dec 19, 2025
d914ba3
add igr forward facing step example
wilfonba Dec 29, 2025
3e92773
update IGR forward facing step example
wilfonba Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 97 additions & 0 deletions examples/2D_IGR_forward_facing_step/case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,97 @@
import json
import math

h = 0.2

# Radius as a percentage of height (h)
rc = 0.2

gam_a = 1.4
p0 = 1
rho0 = 1.4
c0 = math.sqrt(gam_a * p0 / rho0)
v0 = 3 * c0
mu = rho0 * v0 * h / 2e5

# Configuring case dictionary
print(
json.dumps(
{
# Logistics
"run_time_info": "T",
"x_domain%beg": 0,
"x_domain%end": 15 * h,
"y_domain%beg": 0,
"y_domain%end": 5 * h,
"cyl_coord": "F",
"m": 1499,
"n": 499,
"p": 0,
"cfl_adap_dt": "T",
"cfl_target": 0.6,
"n_start": 0,
"t_save": 0.04,
"t_stop": 4,
# Simulation Algorithm Parameters
"num_patches": 1,
"model_eqns": 2,
"alt_soundspeed": "F",
"num_fluids": 1,
"mpp_lim": "F",
"mixture_err": "F",
"time_stepper": 3,
"igr": "T",
"igr_pres_lim": "T",
"igr_order": 3,
"igr_iter_solver": 1,
"num_igr_iters": 5,
"num_igr_warm_start_iters": 50,
"bc_x%beg": -3,
"bc_x%end": -3,
"bc_y%beg": -2,
"bc_y%end": -2,
"ib": "T",
"num_ibs": 3,
# Formatted Database Files Structure Parameters
"format": 1,
"precision": 2,
"prim_vars_wrt": "T",
"parallel_io": "T",
# Patch 1 Background
"patch_icpp(1)%geometry": 3,
"patch_icpp(1)%x_centroid": 7.5 * h,
"patch_icpp(1)%y_centroid": 2.5 * h,
"patch_icpp(1)%length_x": 15 * h,
"patch_icpp(1)%length_y": 5 * h,
"patch_icpp(1)%vel(1)": v0,
"patch_icpp(1)%vel(2)": 0.0,
"patch_icpp(1)%pres": p0,
"patch_icpp(1)%alpha_rho(1)": rho0,
"patch_icpp(1)%alpha(1)": 1.0,
# Patch: Slip rectangle with rouded corner
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Jan 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Typo in comment: "rouded" should be "rounded".

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At examples/2D_IGR_forward_facing_step/case.py, line 71:

<comment>Typo in comment: &quot;rouded&quot; should be &quot;rounded&quot;.</comment>

<file context>
@@ -68,23 +68,23 @@
             &quot;patch_icpp(1)%alpha_rho(1)&quot;: rho0,
             &quot;patch_icpp(1)%alpha(1)&quot;: 1.0,
-            # Patch: No slip rectangle with rouded corner
+            # Patch: Slip rectangle with rouded corner
             &quot;patch_ib(1)%geometry&quot;: 3,
-            &quot;patch_ib(1)%x_centroid&quot;: 11.5 * h + rc*h,
</file context>
Suggested change
# Patch: Slip rectangle with rouded corner
# Patch: Slip rectangle with rounded corner
Fix with Cubic

"patch_ib(1)%geometry": 3,
"patch_ib(1)%x_centroid": (9 + rc / 2) * h,
"patch_ib(1)%y_centroid": 0.5 * h,
"patch_ib(1)%length_x": (12 - rc) * h,
"patch_ib(1)%length_y": h,
"patch_ib(1)%slip": "T",
"patch_ib(2)%geometry": 3,
"patch_ib(2)%x_centroid": (3 + rc/2) * h,
"patch_ib(2)%y_centroid": (0.5 - rc/2) * h,
"patch_ib(2)%length_x": rc * h,
"patch_ib(2)%length_y": (1 - rc) * h,
"patch_ib(2)%slip": "T",
"patch_ib(3)%geometry": 2,
"patch_ib(3)%x_centroid": (3 + rc)*h,
"patch_ib(3)%y_centroid": (1 - rc)*h,
"patch_ib(3)%radius" : rc * h,
"patch_ib(3)%slip": "T",
Comment on lines +76 to +88
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Address the MFC formatting failure.

The CI pipeline reports a formatting error around the patch_ib(2) and patch_ib(3) configuration lines. Run the project's formatter locally to resolve this issue:

./mfc.sh format

After applying the automatic fixes, verify the formatter passes with no changes and commit the reformatted file.

🧰 Tools
🪛 GitHub Actions: Pretty

[error] 76-76: MFC formatting failed. Process exited with code 1. Diff indicates formatting changes around patch_ib(2) and patch_ib(3) centroid/radius lines; run './mfc.sh format' to apply fixes.

🤖 Prompt for AI Agents 
In examples/2D_IGR_forward_facing_step/case.py around lines 76 to 88 the CI
reports MFC formatting failures for the patch_ib(2) and patch_ib(3)
configuration lines; run the project formatter locally with ./mfc.sh format,
review and stage the changes it makes (git add
examples/2D_IGR_forward_facing_step/case.py), verify the formatter now makes no
further changes (re-run ./mfc.sh format) and then commit the reformatted file
with a clear message.

# Fluids Physical Parameters
"fluid_pp(1)%gamma": 1.0 / (gam_a - 1.0),
"fluid_pp(1)%pi_inf": 0.0,
"viscous": "T",
"fluid_pp(1)%Re(1)": 1 / mu,
},
indent=4,
)
)
Loading
Loading