Disable gradients in inference mode

[aartbik]

No description provided.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[reidtatge]

You're just disabling the gradient stuff. Oh, for inference mode. Never mind. Approved.

[aartbik]

You're just disabling the gradient stuff? Any particular reason why?

No, I am disabling gradients only during validation. That's the proper PyTorch setup.

Line 17-28: training, gradients on, model in train mode

Line 31-44: evaluation, gradients off, model in eval mode

[reidtatge]

Yeah, I realized that right after I wrote the message. No problem.

…

On Thu, Apr 17, 2025 at 4:12 PM Aart Bik ***@***.***> wrote: You're just disabling the gradient stuff? Any particular reason why? No, I am disabling gradients *only* during validation. That's the proper PyTorch setup. Line 17-28: training, gradients on, model in train mode Line 31-44: evaluation, gradients off, model in eval mode — Reply to this email directly, view it on GitHub <#80 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIRIKE7WYMJA6NHIWGAZQ3T22AYOTAVCNFSM6AAAAAB3L65XF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJUGE4DGNZSGM> . You are receiving this because your review was requested.Message ID: ***@***.***> *aartbik* left a comment (MPACT-ORG/mpact-compiler#80) <#80 (comment)> You're just disabling the gradient stuff? Any particular reason why? No, I am disabling gradients *only* during validation. That's the proper PyTorch setup. Line 17-28: training, gradients on, model in train mode Line 31-44: evaluation, gradients off, model in eval mode — Reply to this email directly, view it on GitHub <#80 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIRIKE7WYMJA6NHIWGAZQ3T22AYOTAVCNFSM6AAAAAB3L65XF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJUGE4DGNZSGM> . You are receiving this because your review was requested.Message ID: ***@***.***>

[aartbik]

It looks like one of you has to commit this....

[reidtatge]

Done.

…

On Tue, Apr 22, 2025 at 1:01 PM Aart Bik ***@***.***> wrote: It looks like one of you has to commit this.... — Reply to this email directly, view it on GitHub <#80 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIRIKE7AWK4M4WLCBLUEDLD222N27AVCNFSM6AAAAAB3L65XF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRSGM2TANRWGQ> . You are receiving this because your review was requested.Message ID: ***@***.***> *aartbik* left a comment (MPACT-ORG/mpact-compiler#80) <#80 (comment)> It looks like one of you has to commit this.... — Reply to this email directly, view it on GitHub <#80 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIRIKE7AWK4M4WLCBLUEDLD222N27AVCNFSM6AAAAAB3L65XF2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMRSGM2TANRWGQ> . You are receiving this because your review was requested.Message ID: ***@***.***>