Draft
Conversation
added 2 commits
November 24, 2024 17:27
Original commit message: "Added option to provide FSL FIRST data to three scripts which would otherwise run that step repeatedly. Also takes away the FSL dependency in labelsgmfix for Windows users." Manual cherry-pick of dc6d87b by: Robert E. Smith <robert.smith@florey.edu.au>
Manual application of changes in #2330 by: Robert E. Smith <robert.smith@florey.edu.au>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
Member
Author
|
Noting relevance to #3073. For some (not all) MRtrix3 Python commands, it should be possible to take the outputs of third-party software commands as input rather than executing them internally. This would make it possible to utilise an MRtrix3 container that does not encapsulate those third-party softwares; the user would be responsible for generating their derivatives externally. |
Lestropie
force-pushed
the
fsl_first_precalc
branch
from
67c79a8 to
209636e
Compare
Lestropie
force-pushed
the
fsl_first_precalc
branch
from
209636e to
67c79a8
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Conflicts: python/mrtrix3/commands/5ttgen/fsl.py python/mrtrix3/commands/5ttgen/hsvs.py python/mrtrix3/commands/labelsgmfirst.py python/mrtrix3/fsl.py
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work In Progress.
Final relevant changeset being extracted from #2330 to allow its closure. I have extracted the code changes relating to addition of the
-first_diroption tolabelsgmfirst/5ttgen fsl/5ttgen hsvsand applied them todevwith authorship to @nicdc. From here I will need to:devsince edited documentation 5ttgen hsvs -white_stem #2330 was listed. This will include use of f-strings, typed command-line argument variables, ...run.command('cp ...')withshutil