Rage Fighter Killing Blow, Beast Uppercut, Chain Drive, Dragon Roar, Phoenix Shot skills completion #683

ze-dom · 2026-01-02T17:31:30Z

🚧 WIP 🚧

To-do:

Comment changes with references
Update plugin

Developments:

Killing Blow multiple hits and magic effect
Beast Uppercut multiple hits and magic effect
Chain Drive multiple hits and magic effect
Dragon Roar multiple hits and magic effect
Phoenix Shot multiple hits and magic effect

Bugfixes:

…ain drive, dragon roar, phoenix shot

gemini-code-assist · 2026-01-02T17:31:59Z

Summary of Changes

Hello @ze-dom, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the combat system by introducing multi-hit capabilities for several Rage Fighter skills. It involves fundamental changes to skill definitions, attack processing logic, and client-server communication to accurately represent and display these multi-hit sequences and their associated new magic effects. The changes aim to complete the implementation of these specific Rage Fighter skills, making them fully functional within the game.

Highlights

Multi-Hit Skill Implementation: Introduced a NumberOfHitsPerAttack property to the Skill data model, enabling skills to perform multiple hits per single attack action. This is applied to Rage Fighter skills like Killing Blow, Beast Uppercut, Chain Drive, Dragon Roar, and Phoenix Shot.
New Damage Attributes for Rage Fighter Streaks: Added RageFighterStreakHit and RageFighterStreakFinalHit to DamageAttributes to differentiate between non-final and final hits within a multi-hit skill sequence, providing more granular feedback and potential for unique effects.
Updated Attack Logic and Network Communication: Modified the core AttackByAsync method across IAttackable implementations (NPCs, Players, SoccerBall) to accept a new isFinalStreakHit parameter. Client-server packets for hit information (SendObjectHitAsync, SendObjectHitExtendedAsync) were updated to transmit these new streak hit flags, allowing the client to display multi-hit effects correctly.
New Skill Plugins and Magic Effects: Implemented DragonRoarSkillPlugIn and PhoenixShotSkillPlugIn to handle the area-of-effect and multi-target logic for these Rage Fighter skills. Additionally, new magic effects for 'Decrease Block Effect (Phoenix Shot)' and 'Defense Reduction Effect (Beast Uppercut)' were introduced and initialized.
Database Migration: A new database migration (AddSkillNumberOfHitsPerAttack) was added to persist the NumberOfHitsPerAttack property for skills in the database.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces multi-hit skill mechanics for the Rage Fighter class, which is a significant feature addition. The changes span across the data model, game logic, networking, and persistence layers. While the implementation is largely on the right track, there are a few areas that need attention. The logic for handling multi-hit attacks is duplicated in several places, which should be refactored for better maintainability. I've also found a critical bug in the new DragonRoarSkillPlugIn that incorrectly handles single-hit skills. Additionally, there are some minor code quality issues like an inconsistent parameter name and other duplicated logic that should be addressed. Addressing these points will improve the correctness and quality of the code.

gemini-code-assist · 2026-01-02T17:33:19Z

src/GameLogic/PlayerActions/Skills/DragonRoarSkillPlugIn.cs

+            if (i <= 3 || Rand.NextRandomBool())
+            {
+                // first three 100% chance, others 50% chance
+                await extraTarget.AttackByAsync(attacker, skillEntry, false, 1, false).ConfigureAwait(false);


There is a bug in how the first hit is handled. The isFinalStreakHit parameter is hardcoded to false. If a skill has only one hit (skill.NumberOfHitsPerAttack == 1), this parameter should be null. This will cause incorrect behavior for single-hit skills that might use this logic. Please use the same pattern as in AreaSkillAttackAction to correctly handle both single and multi-hit skills.

await extraTarget.AttackByAsync(attacker, skillEntry, false, 1, skill.NumberOfHitsPerAttack > 1 ? false : null).ConfigureAwait(false);

Not possible in this context

gemini-code-assist · 2026-01-02T17:33:19Z

src/GameLogic/NPC/AttackableNpcBase.cs


    /// <inheritdoc />
-    public async ValueTask<HitInfo?> AttackByAsync(IAttacker attacker, SkillEntry? skill, bool isCombo, double damageFactor = 1.0)
+    public async ValueTask<HitInfo?> AttackByAsync(IAttacker attacker, SkillEntry? skill, bool isCombo, double damageFactor = 1.0, bool? isStreakFinalHit = null)


The parameter isStreakFinalHit should be renamed to isFinalStreakHit to match the method signature in the IAttackable interface. Maintaining consistency with the interface definition is important for readability and prevents confusion.

public async ValueTask<HitInfo?> AttackByAsync(IAttacker attacker, SkillEntry? skill, bool isCombo, double damageFactor = 1.0, bool? isFinalStreakHit = null)

gemini-code-assist · 2026-01-02T17:33:19Z

src/GameLogic/Player.cs

+        if (isFinalStreakHit.HasValue)
+        {
+            hitInfo.Attributes |= DamageAttributes.RageFighterStreakHit;
+
+            if (isFinalStreakHit.Value || this.Attributes[Stats.CurrentHealth] < 1)
+            {
+                hitInfo.Attributes |= DamageAttributes.RageFighterStreakFinalHit;
+            }
+        }


This logic for setting the RageFighterStreakHit and RageFighterStreakFinalHit attributes is duplicated from AttackableNpcBase.HitAsync. To improve maintainability and prevent future inconsistencies, this logic should be extracted into a shared helper method. An extension method on HitInfo, such as hitInfo.SetRageFighterStreakAttributes(isFinalStreakHit, isKilled), could be a good approach.

gemini-code-assist · 2026-01-02T17:33:19Z

src/GameLogic/PlayerActions/Skills/AreaSkillAttackAction.cs

+        var hitInfo = await target.AttackByAsync(player, skillEntry, isCombo, 1, skill.NumberOfHitsPerAttack > 1 ? false : null).ConfigureAwait(false);
        await target.TryApplyElementalEffectsAsync(player, skillEntry).ConfigureAwait(false);
+
+        for (int hit = 2; hit <= skill.NumberOfHitsPerAttack; hit++)
+        {
+            await target.AttackByAsync(player, skillEntry, isCombo, 1, hit == skill.NumberOfHitsPerAttack).ConfigureAwait(false);
+        }


The logic for performing a multi-hit attack is duplicated in TargetedSkillDefaultPlugin.cs and DragonRoarSkillPlugIn.cs. To improve maintainability and ensure consistent behavior, this logic should be extracted into a single, reusable helper method. For instance, an extension method like IAttackable.AttackWithMultiHitsAsync(...) would be a suitable solution.

ze-dom · 2026-01-05T11:47:18Z

src/GameLogic/NPC/AttackableNpcBase.cs

+            if (isFinalStreakHit.HasValue)
+            {
+                hitInfo.Attributes |= DamageAttributes.RageFighterStreakHit;
+
+                if (isFinalStreakHit.Value || killed)
+                {
+                    hitInfo.Attributes |= DamageAttributes.RageFighterStreakFinalHit;
+                }
+            }


zTeamS6.3, MuMain 5.2
Apparently the original didn't check if the target has died, which would cause the damage values not to appear if the target didn't die on the final hit: https://www.youtube.com/watch?v=Vo6aI34Y3FE
But this way we can always show the damage values.

ze-dom · 2026-01-05T12:04:41Z

src/GameLogic/PlayerActions/Skills/DragonRoarSkillPlugIn.cs

zTeamS6.3 -> ObjUseSkill.cpp: UseSkill(), SkillAreaMonsterAttack()

ze-dom · 2026-01-05T12:11:10Z

src/GameLogic/PlayerActions/Skills/DragonRoarSkillPlugIn.cs

+    /// <summary>
+    /// Gets the range around the target, in which additional targets are searched.
+    /// </summary>
+    protected virtual short Range => 3;


zTeamS6.3. This is the range from the target.

ze-dom · 2026-01-05T12:11:59Z

src/GameLogic/PlayerActions/Skills/PhoenixShotSkillPlugIn.cs

+    public override short Key => 270;
+
+    /// <inheritdoc />
+    protected override short Range => 2;


zTeamS6.3. This is the range from the target.

ze-dom · 2026-01-05T12:17:12Z

src/GameLogic/PlayerActions/Skills/DragonRoarSkillPlugIn.cs

+            return false;
+        }
+
+        var extraTargets = target.CurrentMap?.GetAttackablesInRange(target.Position, this.Range).Where(FilterTarget).Take(7);


zTeamS6.3. We take only 7 since we have already hit 1 earlier and 8 is the maximum for the skill.

ze-dom · 2026-01-05T12:17:29Z

src/GameLogic/PlayerActions/Skills/DragonRoarSkillPlugIn.cs

+        {
+            if (i <= 3 || Rand.NextRandomBool())
+            {
+                // first three 100% chance, others 50% chance


ze-dom · 2026-01-05T12:19:16Z

src/GameLogic/PlayerActions/Skills/PhoenixShotSkillPlugIn.cs

zTeamS6.3 -> ObjUseSkill.cpp: UseSkill(), SkillAreaMonsterAttack()

ze-dom · 2026-01-05T12:42:41Z

src/Network/Packets/ServerToClient/ConnectionExtensions.cs

            packet.HealthDamage = @healthDamage;
            packet.Kind = @kind;
+            packet.IsRageFighterStreakHit = @isRageFighterStreakHit;
+            packet.IsRageFighterStreakFinalHit = @isRageFighterStreakFinalHit;


Was IsRageFighterStreakHit & IsRageFighterStreakFinalHit added as a custom addition or is it because these new fields hadn't been added to the main version (version 5.2) yet?

They aren't custom. They were simply missing in the server. As you can see, the client has them.

ze-dom · 2026-01-05T12:46:51Z

src/Network/Packets/ServerToClient/ServerToClientPackets.cs

+        /// Light pink color, usually used by reflected damage.
        /// </summary>
-            LightPink = 4,
+            ReflectedLightPink = 4,


zTeamS6.3, emu

ze-dom · 2026-01-05T12:59:14Z

src/Persistence/Initialization/Skills/DecreaseBlockEffectInitializer.cs

zTeamS6.3 does not have this magic efffect for Phoenix Shot skill, but emu does.
This is a Spanish reference; it states that this effect already existed in S6E2. I found the same thing on Webzen.kr.

ze-dom · 2026-01-05T15:01:21Z

src/Persistence/Initialization/Skills/DefenseReductionBeastUppercutEffectInitializer.cs

zTeamS6.3, emu

ze-dom · 2026-01-05T15:13:19Z

src/Persistence/Initialization/Skills/IncreaseHealthEffectInitializer.cs

        powerUpDefinition.Boost = this.Context.CreateNew<PowerUpDefinitionValue>();
        powerUpDefinition.Boost.ConstantValue.Value = 16f;
        powerUpDefinition.Boost.ConstantValue.AggregateType = AggregateType.AddFinal;
+        powerUpDefinition.Boost.MaximumValue = 200f;


zTeamS6.3 (no data), emu, MuMain 5.2, PR#652

ze-dom · 2026-01-05T15:17:48Z

src/Persistence/Initialization/VersionSeasonSix/SkillsInitializer.cs

        { SkillNumber.Innovation, MagicEffectNumber.Innovation },
        { SkillNumber.DamageReflection, MagicEffectNumber.Reflection },
+        { SkillNumber.BeastUppercut, MagicEffectNumber.DefenseReductionBeastUppercut },
+        { SkillNumber.PhoenixShot, MagicEffectNumber.DecreaseBlock },


ze-dom · 2026-01-05T15:22:52Z

src/Persistence/Initialization/VersionSeasonSix/SkillsInitializer.cs

        { SkillNumber.Weakness, MagicEffectNumber.WeaknessSummoner },
        { SkillNumber.Innovation, MagicEffectNumber.Innovation },
        { SkillNumber.DamageReflection, MagicEffectNumber.Reflection },
+        { SkillNumber.BeastUppercut, MagicEffectNumber.DefenseReductionBeastUppercut },


zTeamS6.3, emu

ze-dom · 2026-01-05T15:27:27Z

src/Persistence/Initialization/Skills/SkillsInitializerBase.cs

+                    skill.MagicEffectDef.Chance = this.Context.CreateNew<PowerUpDefinitionValue>();
+                    skill.MagicEffectDef.Chance.ConstantValue.Value = 0.4f;
+                }
+


zTeamS6.3, emu

ze-dom · 2026-01-05T15:30:32Z

src/Persistence/Initialization/Skills/MagicEffectNumber.cs

+    /// The decrease block effect of the rage fighter.
+    /// </summary>
+    DecreaseBlock = 132,
+


emu: BuffEffect_.h, ObjUseSkill.cpp

ze-dom · 2026-01-05T15:35:58Z

src/Persistence/Initialization/VersionSeasonSix/SkillsInitializer.cs

-        this.CreateSkill(SkillNumber.KillingBlow, "Killing Blow", CharacterClasses.AllFighters, DamageType.Physical, distance: 2, manaConsumption: 9, elementalModifier: ElementalType.Earth);
-        this.CreateSkill(SkillNumber.BeastUppercut, "Beast Uppercut", CharacterClasses.AllFighters, DamageType.Physical, distance: 2, manaConsumption: 9, elementalModifier: ElementalType.Fire);
-        this.CreateSkill(SkillNumber.ChainDrive, "Chain Drive", CharacterClasses.AllFighters, DamageType.Physical, distance: 4, abilityConsumption: 20, manaConsumption: 15, levelRequirement: 150, elementalModifier: ElementalType.Ice);
+        this.CreateSkill(SkillNumber.KillingBlow, "Killing Blow", CharacterClasses.AllFighters, DamageType.Physical, distance: 2, manaConsumption: 9, elementalModifier: ElementalType.Earth, hitsPerAttack: 4); // 1 packet => 1*4 hits


zTeamS6.3, emu, Webzen

ze-dom · 2026-01-05T15:39:19Z

src/Persistence/Initialization/VersionSeasonSix/SkillsInitializer.cs

-        this.CreateSkill(SkillNumber.BeastUppercut, "Beast Uppercut", CharacterClasses.AllFighters, DamageType.Physical, distance: 2, manaConsumption: 9, elementalModifier: ElementalType.Fire);
-        this.CreateSkill(SkillNumber.ChainDrive, "Chain Drive", CharacterClasses.AllFighters, DamageType.Physical, distance: 4, abilityConsumption: 20, manaConsumption: 15, levelRequirement: 150, elementalModifier: ElementalType.Ice);
+        this.CreateSkill(SkillNumber.KillingBlow, "Killing Blow", CharacterClasses.AllFighters, DamageType.Physical, distance: 2, manaConsumption: 9, elementalModifier: ElementalType.Earth, hitsPerAttack: 4); // 1 packet => 1*4 hits
+        this.CreateSkill(SkillNumber.BeastUppercut, "Beast Uppercut", CharacterClasses.AllFighters, DamageType.Physical, distance: 2, manaConsumption: 9, elementalModifier: ElementalType.Fire, hitsPerAttack: 2);  // 2 packets => 2*2 hits


zTeamS6.3 (maybe there was only 1 packet previously?), emu. Webzen

ze-dom · 2026-01-05T15:53:22Z

src/Persistence/Initialization/VersionSeasonSix/SkillsInitializer.cs

-        this.CreateSkill(SkillNumber.ChainDrive, "Chain Drive", CharacterClasses.AllFighters, DamageType.Physical, distance: 4, abilityConsumption: 20, manaConsumption: 15, levelRequirement: 150, elementalModifier: ElementalType.Ice);
+        this.CreateSkill(SkillNumber.KillingBlow, "Killing Blow", CharacterClasses.AllFighters, DamageType.Physical, distance: 2, manaConsumption: 9, elementalModifier: ElementalType.Earth, hitsPerAttack: 4); // 1 packet => 1*4 hits
+        this.CreateSkill(SkillNumber.BeastUppercut, "Beast Uppercut", CharacterClasses.AllFighters, DamageType.Physical, distance: 2, manaConsumption: 9, elementalModifier: ElementalType.Fire, hitsPerAttack: 2);  // 2 packets => 2*2 hits
+        this.CreateSkill(SkillNumber.ChainDrive, "Chain Drive", CharacterClasses.AllFighters, DamageType.Physical, distance: 4, abilityConsumption: 20, manaConsumption: 15, levelRequirement: 150, elementalModifier: ElementalType.Ice, hitsPerAttack: 4); // 2 packets => 2*4 hits


zTeamS6.3 (variable hits 4-7; following this, this might have been an earlier implementation; maybe there was only 1 packet previously?), emu, Webzen

ze-dom · 2026-01-05T15:55:58Z

src/Persistence/Initialization/VersionSeasonSix/SkillsInitializer.cs

+        this.CreateSkill(SkillNumber.ChainDrive, "Chain Drive", CharacterClasses.AllFighters, DamageType.Physical, distance: 4, abilityConsumption: 20, manaConsumption: 15, levelRequirement: 150, elementalModifier: ElementalType.Ice, hitsPerAttack: 4); // 2 packets => 2*4 hits
        this.CreateSkill(SkillNumber.DarkSide, "Dark Side", CharacterClasses.AllFighters, DamageType.Physical, distance: 4, manaConsumption: 70, levelRequirement: 180, elementalModifier: ElementalType.Wind);
-        this.CreateSkill(SkillNumber.DragonRoar, "Dragon Roar", CharacterClasses.AllFighters, DamageType.Physical, distance: 3, abilityConsumption: 30, manaConsumption: 50, levelRequirement: 150, elementalModifier: ElementalType.Earth, skillType: SkillType.AreaSkillAutomaticHits);
+        this.CreateSkill(SkillNumber.DragonRoar, "Dragon Roar", CharacterClasses.AllFighters, DamageType.Physical, distance: 3, abilityConsumption: 30, manaConsumption: 50, levelRequirement: 150, elementalModifier: ElementalType.Earth, skillType: SkillType.AreaSkillExplicitTarget, hitsPerAttack: 4); // 1 packet => 1*4 hits


zTeamS6.3, emu, Webzen

ze-dom · 2026-01-05T15:56:31Z

src/Persistence/Initialization/VersionSeasonSix/SkillsInitializer.cs

        this.CreateSkill(SkillNumber.IncreaseBlock, "Increase Block", CharacterClasses.AllFighters, DamageType.Physical, distance: 7, abilityConsumption: 10, manaConsumption: 50, levelRequirement: 50, energyRequirement: 80, skillType: SkillType.Buff, skillTarget: SkillTarget.ImplicitParty);
        this.CreateSkill(SkillNumber.Charge, "Charge", CharacterClasses.AllFighters, DamageType.Physical, 90, 4, 15, 20);
-        this.CreateSkill(SkillNumber.PhoenixShot, "Phoenix Shot", CharacterClasses.AllFighters, DamageType.Physical, distance: 4, manaConsumption: 30, elementalModifier: ElementalType.Earth, skillType: SkillType.AreaSkillExplicitTarget);
+        this.CreateSkill(SkillNumber.PhoenixShot, "Phoenix Shot", CharacterClasses.AllFighters, DamageType.Physical, distance: 4, manaConsumption: 30, elementalModifier: ElementalType.Earth, skillType: SkillType.AreaSkillExplicitTarget, hitsPerAttack: 4); // 1 packet => 1*4 hits


zTeamS6.3, emu, Webzen

ze-dom · 2026-01-08T18:18:10Z

src/GameLogic/AttackableExtensions.cs

+                {
+                    result += (int)masterSkillEntry.CalculateValue();
+                }
+            }


If the TargetAttribute is null we assume the skill adds damage. We need to go all the way back to the ancestor master skills because some may add damage.

ze-dom · 2026-01-08T18:19:43Z

src/GameLogic/Attributes/MonsterAttributeHolder.cs

+                attribute.AddElement(new SimpleElement { Value = attrValue });
+            }
+
            attributeDictionary.Add(targetAttribute, attribute);


I need this to make Stats.DefenseDecrement work. Do you see any issues?

ze-dom · 2026-01-08T18:37:39Z

src/Persistence/Initialization/CharacterClasses/ClassSummoner.cs

        result.AttributeCombinations.Add(this.CreateAttributeRelationship(Stats.MaximumHealth, 1, finalBerserkerHealthDecrement, InputOperator.Add, AggregateType.Multiplicate));
-        result.AttributeCombinations.Add(this.CreateConditionalRelationship(Stats.DefensePvm, statsDefense, finalBerserkerHealthDecrement, AggregateType.AddFinal));
-        result.AttributeCombinations.Add(this.CreateConditionalRelationship(Stats.DefensePvp, statsDefense, finalBerserkerHealthDecrement, AggregateType.AddFinal));
+        result.AttributeCombinations.Add(this.CreateConditionalRelationship(Stats.DefenseFinal, statsDefense, finalBerserkerHealthDecrement, AggregateType.AddFinal));


Since Fire Slash's reduction (now pooled into Stats.DefenseDecrement) is no longer applied before the berserker penalty, we can simplify this.

ze-dom · 2026-01-09T11:07:36Z

src/Persistence/Initialization/VersionSeasonSix/SkillsInitializer.cs

+        this.AddMasterSkillDefinition(SkillNumber.KillingBlowMastery, SkillNumber.KillingBlowStrengthener, SkillNumber.Undefined, 2, 3, SkillNumber.KillingBlowStrengthener, 20, $"{Formula120} / 100", Formula120, Stats.WeaknessPhysDmgDecrement, AggregateType.AddRaw);
+        this.AddMasterSkillDefinition(SkillNumber.BeastUppercutMastery, SkillNumber.BeastUppercutStrengthener, SkillNumber.Undefined, 2, 3, SkillNumber.BeastUppercutStrengthener, 20, $"{Formula120} / 100", Formula120, Stats.DefenseDecrement, AggregateType.Multiplicate);


zTeamS6.3, emu

The S6E3 client actually has wrong descriptions of these master skills, as they are not the regular skills' magic effects (I've seen this before 😅):

ze-dom added 3 commits December 23, 2025 16:38

Added logic for rage fighter skills: killing blow, beast uppercut, ch…

50e525d

…ain drive, dragon roar, phoenix shot

Merge branch 'sleep-followup' into rage_fighter_skills

f7daba5

Merge branch 'master' into rage_fighter_skills

b16fca4

gemini-code-assist bot reviewed Jan 2, 2026

View reviewed changes

ze-dom added 2 commits January 2, 2026 17:46

Changed parameter name

c20283a

Added update plugin and master skills changes

b204f6b

ze-dom commented Jan 5, 2026

View reviewed changes

src/Persistence/Initialization/Skills/DefenseReductionBeastUppercutEffectInitializer.cs

Copy link

Contributor Author

ze-dom Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zTeamS6.3, emu

ze-dom commented Jan 5, 2026

View reviewed changes

ze-dom added 2 commits January 5, 2026 16:26

Merge branch 'master' into rage_fighter_skills

59d3d91

Fixed master skills for killing blow and beast uppercut

89f9d87

ze-dom commented Jan 8, 2026

View reviewed changes

Updated update plugin

d22890a

ze-dom commented Jan 9, 2026

View reviewed changes

Fixed Stats.DefenseDecrease relationships logic

b2464fe

		this.AddMasterSkillDefinition(SkillNumber.KillingBlowMastery, SkillNumber.KillingBlowStrengthener, SkillNumber.Undefined, 2, 3, SkillNumber.KillingBlowStrengthener, 20, $"{Formula120} / 100", Formula120, Stats.WeaknessPhysDmgDecrement, AggregateType.AddRaw);
		this.AddMasterSkillDefinition(SkillNumber.BeastUppercutMastery, SkillNumber.BeastUppercutStrengthener, SkillNumber.Undefined, 2, 3, SkillNumber.BeastUppercutStrengthener, 20, $"{Formula120} / 100", Formula120, Stats.DefenseDecrement, AggregateType.Multiplicate);

Rage Fighter Killing Blow, Beast Uppercut, Chain Drive, Dragon Roar, Phoenix Shot skills completion #683

Are you sure you want to change the base?

Rage Fighter Killing Blow, Beast Uppercut, Chain Drive, Dragon Roar, Phoenix Shot skills completion #683

Uh oh!

Conversation

ze-dom commented Jan 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Jan 2, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 2, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

ze-dom commented Jan 2, 2026 •

edited

Loading

ze-dom Jan 5, 2026 •

edited

Loading

ze-dom Jan 5, 2026 •

edited

Loading

ze-dom Jan 5, 2026 •

edited

Loading

ze-dom Jan 5, 2026 •

edited

Loading