patch to __attribute__ ((visibility ("default"))) on exported functions#241
Open
mattip wants to merge 6 commits intoMacPython:mainfrom
Open
patch to __attribute__ ((visibility ("default"))) on exported functions#241mattip wants to merge 6 commits intoMacPython:mainfrom
mattip wants to merge 6 commits intoMacPython:mainfrom
Conversation
Collaborator
Author
I added the
Both these functions have generic equivalents in the |
This was referenced Dec 12, 2025
15fdb72 to
7924b67
Compare
7924b67 to
8ebbba2
Compare
Collaborator
Author
|
In the upstream PR, I defined a new |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git describe --tags --abbrev=8in OpenBLAS at theOPENBLAS_COMMIT. If I did not updateOPENBLAS_COMMIT, I incremented the wheel build number (i.e. 0.3.29.0.0 to 0.3.29.0.1)This is a proof of concept that works to hide functions from exposing them from the shared object on posix
CFLAGS+=-fvisibility=hiddento hide by default__attribute__ ((visibility ("default")))in all the exported function definitionsUseAdd aNO_LAPACKE=1to avoid building (and exporting) legacy lapack routinesfilter-outfor-fvisibility=hiddenin the lapacke MakefilesFor me this solves numpy/numpy#30299, it no longer segfaults. Although when I look at ltrace I still see that a global openblas is overriding the function
dgemm_kernel_HASWELLin the call toscipy_cblas_dgemm64_at NumPy import.