Merged
Conversation
Collaborator
|
30 minutes per job isn't too bad, and this diff is quite clean, looks good! This accumulated a small merge conflict unfortunately, could you please resolve that @ffgan? |
Collaborator
|
@mattip this seems reasonable to me to add as is, it's about as fast as |
Co-authored by: nijincheng@iscas.ac.cn; Signed-off-by: ffgan <sudoemt@gmail.com>
Co-authored by: nijincheng@iscas.ac.cn; Signed-off-by: ffgan <sudoemt@gmail.com>
8ba5537 to
c3255d9
Compare
Collaborator
|
Thanks @ffgan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./openblas_commit.txt. If I did not update./openblas_commit.txt, I incremented the wheel build number (i.e. 0.3.29.0.0 to 0.3.29.0.1)Note: update
./openblas_commit.txtwithcd OpenBLAS; git describe --tags --abbrev=8 > ../openblas_commit.txtclose #226
Cross-compiling riscv64 on arm64 takes less time than cross-compiling riscv64 on x86, completing in about half an hour, which is similar to cross-compiling s390x on arm64. Perhaps we can consider adding riscv64 support for openblas-libs.
I ran the CI in my fork, and the results show everything went smoothly. For details, check here.
Other Info
Co-authored by: nijincheng@iscas.ac.cn;