Add MetaTag support for backwards compatibility with ProfileService#18
Open
walkerrobertben wants to merge 1 commit intoMadStudioRoblox:mainfrom
Open
Add MetaTag support for backwards compatibility with ProfileService#18walkerrobertben wants to merge 1 commit intoMadStudioRoblox:mainfrom
walkerrobertben wants to merge 1 commit intoMadStudioRoblox:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MetaTag support for backwards compatibility with ProfileService
Overview
This PR addsProfile:GetMetaTag()andProfile:SetMetaTag()methods to ProfileStore, providing backwards compatibility with ProfileService's MetaTag functionality. These methods allow storing and retrieving metadata separate fromProfile.Data, which persists toProfile.MetaData.MetaTagswhen profiles are saved.Motivation
As a long-term ProfileService user migrating to ProfileStore, I needed to maintain compatibility with existing code that relies on MetaTags. ProfileStore removes MetaTags in favor ofProfile.LastSavedDatafor data verification. My custom version control system depends on MetaTags for tracking changes, and since ProfileStore is otherwise functionally backwards-compatible, adding these methods was the minimal change needed to complete the migration.Changes Made
MetaTagsfield to Profile instances, initialized fromraw_data.MetaData.MetaTagsprofile.MetaTagstolatest_data.MetaData.MetaTagsProfile:GetMetaTag(tag_name)andProfile:SetMetaTag(tag_name, value)methods with input validationGetMetaTagandSetMetaTagmethods with usage examples and backwards compatibility notesTesting
Compatibility
These methods are purely additive and do not affect existing ProfileStore functionality. They exist solely for legacy ProfileService integrations that require MetaTag access. The documentation clearly marks them as legacy support methods.