Fixing project directory creation handling & name edition when custom folder selected #156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! First contribution here.
Commit 839b4c4 aim to fix #149 by creating folder only when
_create_folder_checkis checked on the dialog UI, else it directly emits the signal.Commit 1fcef2c aim to fix an issue that wrongly reset the content of the
_project_path_line_edit.textto the default config projects folder when editing the_project_name_edit.text.In the commit, if
_create_folder_checkis checked, it should add a sanitized_project_name_edit.textto the current path after the last parent folder (fetched with thesubstr()andrfind()present in the commit).If the
_create_folder_checkis not checked, we keep the implementation as it is, pulling the config default projects folder and adding the project name.As writing this, forgot to sanitize the project name, fixing this and this should be ready to merge.