-
Notifications
You must be signed in to change notification settings - Fork 4
Renderer upgrade #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Renderer upgrade #868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f48a5f4 to
f53cc7d
Compare
Contributor
|
Rebased to fix CI build so that ManiVaultStudio/ExamplePlugins#42, ManiVaultStudio/Scatterplot#173 and ManiVaultStudio/ImageViewerPlugin#146 build fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim of the PR
The primary objective of this PR is to use all the screen estate in 2D point and density-based renderers. Previously, due to square rendering constraints, rendering space was not always used optimally. This PR solves that problem, along with some overdue partial overhaul of rendering base classes.
Requires this scatterplot plugin PR for full review.
Newly introduced classes
mv::Renderer2D, a rendering base class that generalizes common 2D rendering and interaction behavior. It has a navigator for interacting with the camera and contains helper functions to switch between coordinate systems.mv:Navigator2D, a helper navigator class for navigating within 2D renderers. Objects of this class are coupled with a source renderer widget for which it takes care of all mouse events.mv::NavigationAction, a generic action class with a commonly used GUI for 2D and 3D navigation in renderersmv::gui::NumericalPointAction, a numerical base class action for point actionsmv::gui::IntegralPointAction, a point action class for integral points, derived frommv::gui::NumericalPointActionmv::gui::DecimalPointAction, a point action class for decimal points, derived frommv::gui::NumericalPointActionOther changes
zoom to selectionzoom to windowmv::util::StyledIconmv::gui::WidgetActionactions/numericalsource groupvirtual + finalconstructions here and there