Skip to content

Conversation

@u7920349
Copy link

@u7920349 u7920349 commented Oct 25, 2025

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

Updates the installation documentation to include a troubleshooting method for installing the source
files of the project independent of current releases. Closes #4439

Links to added or changed documentation pages

https://docs.manim.community/en/latest/contributing.html

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labelled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the proposed changes and sorry for the long delay -- I've left some suggestions to remove potentially confusing and unnecessary instructions. Please take a look!

Comment on lines +16 to +18
- [X] I have read the [Contributing Guidelines](https://docs.manim.community/en/latest/contributing.html)
- [X] I have written a descriptive PR title (see top of PR template for examples)
- [X] My new documentation builds, looks correctly formatted, and adds no additional build warnings
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be reverted.

Suggested change
- [X] I have read the [Contributing Guidelines](https://docs.manim.community/en/latest/contributing.html)
- [X] I have written a descriptive PR title (see top of PR template for examples)
- [X] My new documentation builds, looks correctly formatted, and adds no additional build warnings
- [ ] I have read the [Contributing Guidelines](https://docs.manim.community/en/latest/contributing.html)
- [ ] I have written a descriptive PR title (see top of PR template for examples)
- [ ] My new documentation builds, looks correctly formatted, and adds no additional build warnings




:::{dropdown} Installing the current repo as a pip package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::{dropdown} Installing the current repo as a pip package
:::{dropdown} Installing the latest development version

Comment on lines +336 to +337
If there are problems with the current release of manim.
You can install the current repository as a pip package by running
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If there are problems with the current release of manim.
You can install the current repository as a pip package by running
If you want to install the latest (potentially unstable!)
development version of Manim from our source repository
[on GitHub](https://github.com/ManimCommunity/manim), then
simply run

Comment on lines +338 to +343

'pip install git+https://github.com/ManimCommunity/manim.git@main'

or

'uv add git+https://github.com/ManimCommunity/manim.git@main'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code fences here are not correct. Like in the sections above, I'd only mention the uv command.

Suggested change
'pip install git+https://github.com/ManimCommunity/manim.git@main'
or
'uv add git+https://github.com/ManimCommunity/manim.git@main'
```
uv add git+https://github.com/ManimCommunity/manim.git@main
```

Comment on lines +345 to +357
If you want to install a specific commit or test some changes to the
source files you'll want to install these packages:

'''
pip install build
pip install bandersnatch
pip install cibuildwheel
'''

After this you should be able to run 'pyproject-build' in the root
of the project to create the package under dist. Under which you can
run the interpreter to install any other dependicies and add it into
the pip package.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems very specific, you shouldn't ever really need to install cibuildwheel or bandersnatch just if you want to get a specific commit. I'd delete this section from the dropdown.

Suggested change
If you want to install a specific commit or test some changes to the
source files you'll want to install these packages:
'''
pip install build
pip install bandersnatch
pip install cibuildwheel
'''
After this you should be able to run 'pyproject-build' in the root
of the project to create the package under dist. Under which you can
run the interpreter to install any other dependicies and add it into
the pip package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

VectorizedPoint being reset to origin by Create()

3 participants