-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Documentation: manual installation of manim as a local package #4456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
behackl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for the proposed changes and sorry for the long delay -- I've left some suggestions to remove potentially confusing and unnecessary instructions. Please take a look!
| - [X] I have read the [Contributing Guidelines](https://docs.manim.community/en/latest/contributing.html) | ||
| - [X] I have written a descriptive PR title (see top of PR template for examples) | ||
| - [X] My new documentation builds, looks correctly formatted, and adds no additional build warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be reverted.
| - [X] I have read the [Contributing Guidelines](https://docs.manim.community/en/latest/contributing.html) | |
| - [X] I have written a descriptive PR title (see top of PR template for examples) | |
| - [X] My new documentation builds, looks correctly formatted, and adds no additional build warnings | |
| - [ ] I have read the [Contributing Guidelines](https://docs.manim.community/en/latest/contributing.html) | |
| - [ ] I have written a descriptive PR title (see top of PR template for examples) | |
| - [ ] My new documentation builds, looks correctly formatted, and adds no additional build warnings |
|
|
||
|
|
||
|
|
||
| :::{dropdown} Installing the current repo as a pip package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| :::{dropdown} Installing the current repo as a pip package | |
| :::{dropdown} Installing the latest development version |
| If there are problems with the current release of manim. | ||
| You can install the current repository as a pip package by running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| If there are problems with the current release of manim. | |
| You can install the current repository as a pip package by running | |
| If you want to install the latest (potentially unstable!) | |
| development version of Manim from our source repository | |
| [on GitHub](https://github.com/ManimCommunity/manim), then | |
| simply run |
|
|
||
| 'pip install git+https://github.com/ManimCommunity/manim.git@main' | ||
|
|
||
| or | ||
|
|
||
| 'uv add git+https://github.com/ManimCommunity/manim.git@main' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code fences here are not correct. Like in the sections above, I'd only mention the uv command.
| 'pip install git+https://github.com/ManimCommunity/manim.git@main' | |
| or | |
| 'uv add git+https://github.com/ManimCommunity/manim.git@main' | |
| ``` | |
| uv add git+https://github.com/ManimCommunity/manim.git@main | |
| ``` |
| If you want to install a specific commit or test some changes to the | ||
| source files you'll want to install these packages: | ||
|
|
||
| ''' | ||
| pip install build | ||
| pip install bandersnatch | ||
| pip install cibuildwheel | ||
| ''' | ||
|
|
||
| After this you should be able to run 'pyproject-build' in the root | ||
| of the project to create the package under dist. Under which you can | ||
| run the interpreter to install any other dependicies and add it into | ||
| the pip package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems very specific, you shouldn't ever really need to install cibuildwheel or bandersnatch just if you want to get a specific commit. I'd delete this section from the dropdown.
| If you want to install a specific commit or test some changes to the | |
| source files you'll want to install these packages: | |
| ''' | |
| pip install build | |
| pip install bandersnatch | |
| pip install cibuildwheel | |
| ''' | |
| After this you should be able to run 'pyproject-build' in the root | |
| of the project to create the package under dist. Under which you can | |
| run the interpreter to install any other dependicies and add it into | |
| the pip package. |
Overview: What does this pull request change?
Motivation and Explanation: Why and how do your changes improve the library?
Updates the installation documentation to include a troubleshooting method for installing the source
files of the project independent of current releases. Closes #4439
Links to added or changed documentation pages
https://docs.manim.community/en/latest/contributing.html
Further Information and Comments
Reviewer Checklist